From: J Bruce Fields <bfields@fieldses.org>
To: Trond Myklebust <trondmy@gmail.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFS: Fix up a typo in nfs_dns_ent_put
Date: Mon, 8 Oct 2018 10:23:35 -0400 [thread overview]
Message-ID: <20181008142335.GA5567@fieldses.org> (raw)
In-Reply-To: <20181005142720.25280-1-trond.myklebust@hammerspace.com>
On Fri, Oct 05, 2018 at 10:27:20AM -0400, Trond Myklebust wrote:
> call_rcu() needs to take a first argument of type (struct rcu_head *).
>
> Fixes: fd497f1e40d9 ("NFS: Lockless DNS lookups")
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Thanks! Applying.--b.
> ---
> - Apologies for the screwup
>
> fs/nfs/dns_resolve.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/dns_resolve.c b/fs/nfs/dns_resolve.c
> index e93a5dc07c8c..a7d3df85736d 100644
> --- a/fs/nfs/dns_resolve.c
> +++ b/fs/nfs/dns_resolve.c
> @@ -116,7 +116,7 @@ static void nfs_dns_ent_put(struct kref *ref)
> struct nfs_dns_ent *item;
>
> item = container_of(ref, struct nfs_dns_ent, h.ref);
> - call_rcu(item, nfs_dns_ent_free_rcu);
> + call_rcu(&item->rcu_head, nfs_dns_ent_free_rcu);
> }
>
> static struct cache_head *nfs_dns_ent_alloc(void)
> --
> 2.17.1
prev parent reply other threads:[~2018-10-08 21:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 14:27 [PATCH] NFS: Fix up a typo in nfs_dns_ent_put Trond Myklebust
2018-10-08 14:23 ` J Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008142335.GA5567@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).