Re: [PATCH 09/29] vfs: combine the clone and dedupe into a single remap_file_range

Darrick J. Wong
2018-10-18T13:03:01Z

On Thu, Oct 18, 2018 at 05:54:29AM +0100, Al Viro wrote:
> On Wed, Oct 17, 2018 at 09:47:18PM -0700, Darrick J. Wong wrote:
>
> > > > +#define REMAP_FILE_DEDUP (1 << 0)
> > > > +
> > > > +/*
> > > > + * These flags should be taken care of by the implementation (possibly using
> > > > + * vfs helpers) but can be ignored by the implementation.
> > > > + */
> > > > +#define REMAP_FILE_ADVISORY (0)
> > >
> > > ???
> >
> > Sorry if this wasn't clear. How about this?
> >
> > /*
> > * These flags signal that the caller is ok with altering various aspects of
> > * the behavior of the remap operation. The changes must be made by the
> > * implementation; the vfs remap helper functions can take advantage of them.
> > * Flags in this category exist to preserve the quirky behavior of the hoisted
> > * btrfs clone/dedupe ioctls.
> > */
>
> Something like "currently we have no such flags, but some will appear
> in subsequent commits", removed once such flags do appear, perhaps?

Done.

--D