From: "J. Bruce Fields" <bfields@fieldses.org>
To: Olga Kornievskaia <olga.kornievskaia@gmail.com>
Cc: "J. Bruce Fields" <bfields@redhat.com>,
linux-nfs <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v1 09/13] NFSD add COPY_NOTIFY operation
Date: Thu, 8 Nov 2018 13:46:03 -0500 [thread overview]
Message-ID: <20181108184603.GA6090@fieldses.org> (raw)
In-Reply-To: <CAN-5tyELmi6Obv-Ak2gikZ8sBfZ2AamaH6YdmjfGV22j7Zyrkw@mail.gmail.com>
On Thu, Nov 08, 2018 at 01:29:26PM -0500, Olga Kornievskaia wrote:
> On Mon, Nov 5, 2018 at 12:50 PM J. Bruce Fields <bfields@fieldses.org> wrote:
> >
> > On Fri, Oct 19, 2018 at 11:29:01AM -0400, Olga Kornievskaia wrote:
> > > @@ -2720,6 +2775,12 @@ static inline u32 nfsd4_seek_rsize(struct svc_rqst *rqstp, struct nfsd4_op *op)
> > > .op_name = "OP_OFFLOAD_CANCEL",
> > > .op_rsize_bop = nfsd4_only_status_rsize,
> > > },
> > > + [OP_COPY_NOTIFY] = {
> > > + .op_func = nfsd4_copy_notify,
> > > + .op_flags = OP_MODIFIES_SOMETHING | OP_CACHEME,
> >
> > CACHEME is actually only used for 4.0, let's drop it from
> > nfs4.1/4.2-only operations.
>
> Ah well COPY And CLONE had the CACHEME and thus I had it. I'll remove
> it. We provably need to remove it from 4.2 ops: COPY, CLONE, ALLOCATE,
> DEALLOCATE...
OK, that could be a separate patch.
--b.
next prev parent reply other threads:[~2018-11-08 18:46 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 15:28 [PATCH v1 00/13] server-side support for "inter" SSC copy Olga Kornievskaia
2018-10-19 15:28 ` [PATCH v1 01/13] fs: Don't copy beyond the end of the file Olga Kornievskaia
2018-10-31 16:54 ` J. Bruce Fields
2018-10-31 17:07 ` Olga Kornievskaia
2018-10-31 17:54 ` J. Bruce Fields
2018-10-31 18:01 ` Olga Kornievskaia
2018-10-31 18:29 ` J. Bruce Fields
2018-10-19 15:28 ` [PATCH v1 02/13] VFS permit cross device vfs_copy_file_range Olga Kornievskaia
2018-10-19 15:28 ` [PATCH v1 03/13] NFS NFSD defining nl4_servers structure needed by both Olga Kornievskaia
2018-10-19 15:28 ` [PATCH v1 04/13] NFS inter ssc open Olga Kornievskaia
2018-10-31 18:40 ` J. Bruce Fields
2018-10-31 18:54 ` Olga Kornievskaia
2018-11-01 20:12 ` J. Bruce Fields
2018-11-01 20:30 ` Olga Kornievskaia
2018-10-19 15:28 ` [PATCH v1 05/13] NFS skip recovery of copy open on dest server Olga Kornievskaia
2018-11-01 20:19 ` J. Bruce Fields
2018-11-01 20:38 ` Olga Kornievskaia
2018-11-01 21:24 ` J. Bruce Fields
2018-10-19 15:28 ` [PATCH v1 06/13] NFSD fill-in netloc4 structure Olga Kornievskaia
2018-11-01 20:37 ` J. Bruce Fields
2018-11-01 20:55 ` Olga Kornievskaia
2018-10-19 15:28 ` [PATCH v1 07/13] NFSD add ca_source_server<> to COPY Olga Kornievskaia
2018-11-01 20:48 ` J. Bruce Fields
2018-11-01 21:00 ` Olga Kornievskaia
2018-11-02 13:53 ` J. Bruce Fields
2018-11-02 14:03 ` J. Bruce Fields
2018-11-02 16:36 ` Olga Kornievskaia
2018-11-02 15:46 ` J. Bruce Fields
2018-11-02 16:35 ` Olga Kornievskaia
2018-11-02 16:49 ` J. Bruce Fields
2018-11-02 17:04 ` Olga Kornievskaia
2018-10-19 15:29 ` [PATCH v1 08/13] NFSD return nfs4_stid in nfs4_preprocess_stateid_op Olga Kornievskaia
2018-11-02 19:05 ` J. Bruce Fields
2018-11-02 19:25 ` Olga Kornievskaia
2018-11-02 19:53 ` J. Bruce Fields
2018-10-19 15:29 ` [PATCH v1 09/13] NFSD add COPY_NOTIFY operation Olga Kornievskaia
2018-11-05 17:50 ` J. Bruce Fields
2018-11-08 18:29 ` Olga Kornievskaia
2018-11-08 18:46 ` J. Bruce Fields [this message]
2018-10-19 15:29 ` [PATCH v1 10/13] NFSD check stateids against copy stateids Olga Kornievskaia
2018-11-05 21:33 ` J. Bruce Fields
2018-11-08 18:43 ` Olga Kornievskaia
2018-10-19 15:29 ` [PATCH v1 11/13] NFSD generalize nfsd4_compound_state flag names Olga Kornievskaia
2018-10-19 15:29 ` [PATCH v1 12/13] NFSD: allow inter server COPY to have a STALE source server fh Olga Kornievskaia
2018-11-07 18:57 ` J. Bruce Fields
2018-11-08 18:51 ` Olga Kornievskaia
2018-11-08 19:25 ` J. Bruce Fields
2018-11-08 19:27 ` J. Bruce Fields
2018-11-08 19:31 ` Olga Kornievskaia
2018-11-08 19:32 ` Olga Kornievskaia
2018-10-19 15:29 ` [PATCH v1 13/13] NFSD add nfs4 inter ssc to nfsd4_copy Olga Kornievskaia
2018-11-07 21:48 ` J. Bruce Fields
2018-11-08 19:16 ` Olga Kornievskaia
2018-11-09 16:23 ` J. Bruce Fields
2018-10-25 16:07 ` [PATCH v1 00/13] server-side support for "inter" SSC copy J. Bruce Fields
2018-10-29 17:54 ` Olga Kornievskaia
2018-10-29 20:53 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108184603.GA6090@fieldses.org \
--to=bfields@fieldses.org \
--cc=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=olga.kornievskaia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).