public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Scott Mayhew <smayhew@redhat.com>
To: trond.myklebust@hammerspace.com, anna.schumaker@netapp.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 0/1] NFSv4: deal with v4.0 servers that request confirmation on reclaim-type opens
Date: Fri, 30 Nov 2018 12:41:50 -0500	[thread overview]
Message-ID: <20181130174151.19448-1-smayhew@redhat.com> (raw)

A Red Hat customer started having problems with open reclaims after a
kernel upgrade.  It turns out that the customer's NFS server is setting
the OPEN4_RESULT_CONFIRM in response to an OPEN(CLAIM_PREVIOUS), which
is not permitted by RFC 7530.

The client used to be able to handle that because nfs4_open_prepare() used
to copy the filehandle from the OPEN args to the OPEN results when doing
an open by filehandle.  That copy was removed by commit 4e2fcac77390
"nfsv4: Use correct inode in _nfs4_opendata_to_nfs4_state()".

It looks to me like adding the copy back in would not affect the
behavior of the nfs4_opendata_get_inode() helper that was added in
4e2fcac77390 (it uses the filehandle to look up the inode when doing an
open by name)... so this patch adds the copy back in and also adds a
warning in the event that the client does receive OPEN4_RESULT_CONFIRM
in response to an OPEN(CLAIM_PREVIOUS).

Scott Mayhew (1):
  NFSv4: deal with v4.0 servers that request confirmation on
    reclaim-type opens

 fs/nfs/nfs4proc.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

-- 
2.17.1


             reply	other threads:[~2018-11-30 17:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-30 17:41 Scott Mayhew [this message]
2018-11-30 17:41 ` [PATCH] NFSv4: deal with v4.0 servers that request confirmation on reclaim-type opens Scott Mayhew
2018-11-30 18:48   ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181130174151.19448-1-smayhew@redhat.com \
    --to=smayhew@redhat.com \
    --cc=anna.schumaker@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox