Re: [PATCH v2 00/10] server-side support for "inter" SSC copy

J. Bruce Fields
2019-01-16T22:08:21Z

On Mon, Jan 14, 2019 at 09:53:10AM -0500, Olga Kornievskaia wrote:
> On Fri, Dec 21, 2018 at 2:08 PM J. Bruce Fields <bfields@redhat.com> wrote:
> >
> > On Thu, Dec 20, 2018 at 01:42:27PM -0500, Olga Kornievskaia wrote:
> > > On Fri, Nov 30, 2018 at 3:03 PM Olga Kornievskaia
> > > <olga.kornievskaia@gmail.com> wrote:
> > > > All the patches (client inter) and this patch series is available
> > > > from git://linux-nfs.org/projects/aglo/linux.git under the "linux-ssc"
> > > > branch
> > > >
> > >
> > > Bruce,
> > >
> > > Do you have comments on this v2? Once VFS has the patches for the
> > > generic copy_file_range() functionality, NFS should be all set to just
> > > used it.
> >
> > Not yet, sorry. I probably won't be able to give it a proper review
> > till the second week in January, feel free to ping me again then.
>
> Any progress on this?

I have some delegation patches I want to get debugged first, hopefully
just a couple more days.

Where does the VFS cross-superblock copy work stand? I remember Dave
Chinner sending some patches but don't see them in 5.0-rc1, on a quick
look.

--b.

>
> > --b.
> >
> > >
> > > > Olga Kornievskaia (10):
> > > > VFS generic copy_file_range() support
> > > > NFS fallback to generic_copy_file_range
> > > > NFSD fill-in netloc4 structure
> > > > NFSD add ca_source_server<> to COPY
> > > > NFSD return nfs4_stid in nfs4_preprocess_stateid_op
> > > > NFSD add COPY_NOTIFY operation
> > > > NFSD check stateids against copy stateids
> > > > NFSD generalize nfsd4_compound_state flag names
> > > > NFSD: allow inter server COPY to have a STALE source server fh
> > > > NFSD add nfs4 inter ssc to nfsd4_copy
> > > >
> > > > fs/nfs/nfs4file.c | 9 +-
> > > > fs/nfsd/Kconfig | 10 ++
> > > > fs/nfsd/nfs4proc.c | 406 ++++++++++++++++++++++++++++++++++++++++++++++-----
> > > > fs/nfsd/nfs4state.c | 124 ++++++++++++++--
> > > > fs/nfsd/nfs4xdr.c | 166 ++++++++++++++++++++-
> > > > fs/nfsd/nfsd.h | 32 ++++
> > > > fs/nfsd/nfsfh.h | 5 +-
> > > > fs/nfsd/nfssvc.c | 6 +
> > > > fs/nfsd/state.h | 21 ++-
> > > > fs/nfsd/xdr4.h | 37 ++++-
> > > > fs/read_write.c | 66 +++++++--
> > > > include/linux/fs.h | 7 +
> > > > include/linux/nfs4.h | 1 +
> > > > mm/filemap.c | 6 +-
> > > > 14 files changed, 810 insertions(+), 86 deletions(-)
> > > >
> > > > --
> > > > 1.8.3.1
> > > >