Re: [PATCH v2 01/10] VFS generic copy_file_range() support

Matthew Wilcox
2018-12-01T21:18:08Z

On Fri, Nov 30, 2018 at 03:03:39PM -0500, Olga Kornievskaia wrote:
> Relax the condition that input files must be from the same
> file systems.

> + ret = do_splice_direct(file_in, &pos_in, file_out, &pos_out,
> + count > MAX_RW_COUNT ? MAX_RW_COUNT : count, 0);

Wasn't there a concern about splicing between filesystems with different
block sizes mentioned the last time this came up? I can't find a citation
for that now.

> - /* this could be relaxed once generic cross fs support is added */
> - if (inode_in->i_sb != inode_out->i_sb) {
> - ret = -EXDEV;
> - goto done;
> - }