From: Catalin Marinas <catalin.marinas@arm.com>
To: Trond Myklebust <trondmy@gmail.com>
Cc: Chuck Lever <chuck.lever@oracle.com>,
Cristian Marussi <cristian.marussi@arm.com>,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH] SUNRPC: Fix RPC receive hangs
Date: Wed, 5 Dec 2018 10:13:06 +0000 [thread overview]
Message-ID: <20181205101306.GA16534@arrakis.emea.arm.com> (raw)
In-Reply-To: <20181204192439.39259-1-trond.myklebust@hammerspace.com>
On Tue, Dec 04, 2018 at 02:24:39PM -0500, Trond Myklebust wrote:
> The RPC code is occasionally hanging when the receive code fails to
> empty the socket buffer due to a partial read of the data. When we
> convert that to an EAGAIN, it appears we occasionally leave data in the
> socket. The fix is to just keep reading until the socket returns
> EAGAIN/EWOULDBLOCK.
>
> Reported-by: Catalin Marinas <catalin.marinas@arm.com>
> Reported-by: Cristian Marussi <cristian.marussi@arm.com>
> Reported-by: Chuck Lever <chuck.lever@oracle.com>
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
It seems to do the trick for me. Thanks.
Tested-by: Catalin Marinas <catalin.marinas@arm.com>
prev parent reply other threads:[~2018-12-05 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 19:24 [PATCH] SUNRPC: Fix RPC receive hangs Trond Myklebust
2018-12-04 19:31 ` Trond Myklebust
2018-12-05 9:14 ` Cristian Marussi
2018-12-05 10:13 ` Cristian Marussi
2018-12-05 10:13 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205101306.GA16534@arrakis.emea.arm.com \
--to=catalin.marinas@arm.com \
--cc=chuck.lever@oracle.com \
--cc=cristian.marussi@arm.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox