Re: [PATCH 4.14 0/2] Two nfsd4 fixes for 4.14 longterm

J. Bruce Fields
2019-02-05T21:31:49Z

ACK to both, thanks.--b.

On Tue, Feb 05, 2019 at 11:01:39AM +0100, Donald Buczek wrote:
> Please include the upstream patches
>
> * commit 085def3ade52 ("nfsd4: fix cached replies to solo SEQUENCE
> compounds")
> * commit 53da6a53e1d4 ("nfsd4: catch some false session retries")
>
> into longterm kernel 4.14.
>
> Because these patches went upstream in 4.15, they are already
> included in longterm 4.19 and stable.
>
> A nfsd4 server failure, where the server sends unrelated replies
> to client requests containing only SEQUENCE operations has been
> experienced with kernel version 4.14.87 [1]. Because the client
> retries endlessly, this completely breaks the nfs mount.
>
> A backport of these patches has been suggested by the patch
> author J. Bruce Fields. [1]
>
> Only limited testing has been done (running a single server with
> 4.14.96 and these two patches for a week and generating some high
> load on it). It can not be proven by testing, that the patches
> really fix the experienced problem. However, as the patches are
> part of upstream and stable kernels for over a year
> they should be a save pick.
>
> Backport note: Only line numbers updated.
>
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=202435
>
> J. Bruce Fields (2):
> nfsd4: fix cached replies to solo SEQUENCE compounds
> nfsd4: catch some false session retries
>
> fs/nfsd/nfs4state.c | 57 ++++++++++++++++++++++++++++++++++++++++-----
> fs/nfsd/state.h | 2 ++
> fs/nfsd/xdr4.h | 13 +++++++++--
> 3 files changed, 64 insertions(+), 8 deletions(-)
>
> --
> 2.20.0