Re: [PATCH v2 06/10] NFSD add COPY_NOTIFY operation

J. Bruce Fields
2019-02-20T14:04:07Z

On Tue, Feb 19, 2019 at 09:07:32PM -0500, J. Bruce Fields wrote:
> On Fri, Nov 30, 2018 at 03:03:44PM -0500, Olga Kornievskaia wrote:
> > diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> > index 879ddc6..c9fb625 100644
> > --- a/fs/nfsd/nfs4xdr.c
> > +++ b/fs/nfsd/nfs4xdr.c
> ...
> > + /* cnr_lease_time */
> > + p = xdr_encode_hyper(p, cn->cpn_sec);
> > + *p++ = cpu_to_be32(cn->cpn_nsec);
>
> This is redundant; xdr_encode_hyper already wrote cn->cpn_sec.

Um, I completely missed the sec/nsec distinction, never mind me.

--b.