public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Scott Mayhew <smayhew@redhat.com>
Cc: jlayton@kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [pynfs PATCH 1/4] nfs4.1: add some reboot tests
Date: Fri, 15 Mar 2019 15:43:44 -0400	[thread overview]
Message-ID: <20190315194344.GA13567@fieldses.org> (raw)
In-Reply-To: <20190314211210.7454-2-smayhew@redhat.com>

On Thu, Mar 14, 2019 at 05:12:07PM -0400, Scott Mayhew wrote:
> +def doTestRebootWithNClients(t, env, n=10):
> +    boot_time = int(time.time())
> +    lease_time = 90

Looks like these two variables aren't used till they're set again a
little further down, so I'll delete these two lines.

--b.

> +    states = []
> +    block = env.c1.new_client_session("%s_block" % env.testname(t))
> +    for i in range(n):
> +        name = "%s_client_%i" % (env.testname(t), i)
> +        owner = "owner_%s" % name
> +        c = env.c1.new_client(name)
> +        sess = c.create_session()
> +        reclaim_complete(sess)
> +        fh, stateid = create_confirm(sess, owner)
> +        states.append(State(name, owner, c, sess, fh))
> +    lease_time = _getleasetime(sess)
> +    boot_time = _waitForReboot(env)

  reply	other threads:[~2019-03-15 19:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-14 21:12 [pynfs PATCH 0/4] nfs4.1: add a bunch of reboot tests Scott Mayhew
2019-03-14 21:12 ` [pynfs PATCH 1/4] nfs4.1: add some " Scott Mayhew
2019-03-15 19:43   ` J. Bruce Fields [this message]
2019-03-15 19:52     ` Scott Mayhew
2019-03-15 20:50       ` J. Bruce Fields
2019-03-15 20:48   ` J. Bruce Fields
2019-03-18 14:30     ` Frank Filz
2019-03-18 14:57       ` 'J. Bruce Fields'
2019-03-14 21:12 ` [pynfs PATCH 2/4] nfs4.1: add some more " Scott Mayhew
2019-03-14 21:12 ` [pynfs PATCH 3/4] nfs4.1: still " Scott Mayhew
2019-03-14 21:12 ` [pynfs PATCH 4/4] nfs4.1: test delayed reclaim following a server reboot Scott Mayhew
2019-03-14 21:48 ` [pynfs PATCH 0/4] nfs4.1: add a bunch of reboot tests J. Bruce Fields
2019-03-14 23:18   ` Scott Mayhew
2019-03-15  1:00     ` J. Bruce Fields
2019-03-15  1:03       ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190315194344.GA13567@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=smayhew@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox