From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@01.org, Trond Myklebust <trondmy@gmail.com>
Cc: kbuild-all@01.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 19/25] NFS: Replace custom error reporting mechanism with generic one
Date: Mon, 1 Apr 2019 09:36:27 +0300 [thread overview]
Message-ID: <20190401063627.GW32613@kadam> (raw)
In-Reply-To: <20190328205239.29674-20-trond.myklebust@hammerspace.com>
Hi Trond,
url: https://github.com/0day-ci/linux/commits/Trond-Myklebust/Fix-up-soft-mounts-for-NFSv4-x/20190331-130454
base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
New smatch warnings:
fs/nfs/write.c:1849 nfs_commit_release_pages() error: we previously assumed 'req->wb_page' could be null (see line 1840)
fs/nfs/write.c:1850 nfs_commit_release_pages() warn: variable dereferenced before check 'req->wb_page' (see line 1849)
# https://github.com/0day-ci/linux/commit/2f2cfd52810bf732da40334bf590dbadda75d6cf
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 2f2cfd52810bf732da40334bf590dbadda75d6cf
vim +1849 fs/nfs/write.c
c9d8f89d9 Trond Myklebust 2008-04-15 1829
f453a54a0 Fred Isaman 2012-04-20 1830 static void nfs_commit_release_pages(struct nfs_commit_data *data)
c9d8f89d9 Trond Myklebust 2008-04-15 1831 {
c9d8f89d9 Trond Myklebust 2008-04-15 1832 struct nfs_page *req;
c9d8f89d9 Trond Myklebust 2008-04-15 1833 int status = data->task.tk_status;
f453a54a0 Fred Isaman 2012-04-20 1834 struct nfs_commit_info cinfo;
353db7966 NeilBrown 2014-09-24 1835 struct nfs_server *nfss;
788e7a89a Trond Myklebust 2006-03-20 1836
^1da177e4 Linus Torvalds 2005-04-16 1837 while (!list_empty(&data->pages)) {
^1da177e4 Linus Torvalds 2005-04-16 1838 req = nfs_list_entry(data->pages.next);
^1da177e4 Linus Torvalds 2005-04-16 1839 nfs_list_remove_request(req);
67911c8f1 Anna Schumaker 2016-01-19 @1840 if (req->wb_page)
^^^^^^^^^^^^
d6d6dc7cd Fred Isaman 2012-03-08 1841 nfs_clear_page_commit(req->wb_page);
^1da177e4 Linus Torvalds 2005-04-16 1842
1e8968c5b Niels de Vos 2013-12-17 1843 dprintk("NFS: commit (%s/%llu %d@%lld)",
3d4ff43d8 Al Viro 2011-06-22 1844 req->wb_context->dentry->d_sb->s_id,
2b0143b5c David Howells 2015-03-17 1845 (unsigned long long)NFS_FILEID(d_inode(req->wb_context->dentry)),
^1da177e4 Linus Torvalds 2005-04-16 1846 req->wb_bytes,
^1da177e4 Linus Torvalds 2005-04-16 1847 (long long)req_offset(req));
c9d8f89d9 Trond Myklebust 2008-04-15 1848 if (status < 0) {
2f2cfd528 Trond Myklebust 2019-03-28 @1849 nfs_mapping_set_error(req->wb_page, status);
^^^^^^^^^^^^
Dereferenced inside function probably?
38a33101d Kinglong Mee 2017-03-09 @1850 if (req->wb_page)
^^^^^^^^^^^^
Too late.
^1da177e4 Linus Torvalds 2005-04-16 1851 nfs_inode_remove_request(req);
ddeaa6379 Joe Perches 2016-10-15 1852 dprintk_cont(", error = %d\n", status);
^1da177e4 Linus Torvalds 2005-04-16 1853 goto next;
^1da177e4 Linus Torvalds 2005-04-16 1854 }
^1da177e4 Linus Torvalds 2005-04-16 1855
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
prev parent reply other threads:[~2019-04-01 6:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 20:52 [PATCH 00/25] Fix up soft mounts for NFSv4.x Trond Myklebust
2019-03-28 20:52 ` [PATCH 01/25] SUNRPC: Fix up task signalling Trond Myklebust
2019-03-28 20:52 ` [PATCH 02/25] SUNRPC: Refactor rpc_restart_call/rpc_restart_call_prepare Trond Myklebust
2019-03-28 20:52 ` [PATCH 03/25] SUNRPC: Refactor xprt_request_wait_receive() Trond Myklebust
2019-03-28 20:52 ` [PATCH 04/25] SUNRPC: Refactor rpc_sleep_on() Trond Myklebust
2019-03-28 20:52 ` [PATCH 05/25] SUNRPC: Remove unused argument 'action' from rpc_sleep_on_priority() Trond Myklebust
2019-03-28 20:52 ` [PATCH 06/25] SUNRPC: Add function rpc_sleep_on_timeout() Trond Myklebust
2019-03-28 20:52 ` [PATCH 07/25] SUNRPC: Fix up tracking of timeouts Trond Myklebust
2019-03-28 20:52 ` [PATCH 08/25] SUNRPC: Ensure that the transport layer respect major timeouts Trond Myklebust
2019-03-28 20:52 ` [PATCH 09/25] SUNRPC: Add tracking of RPC level errors Trond Myklebust
2019-03-28 20:52 ` [PATCH 10/25] SUNRPC: Make "no retrans timeout" soft tasks behave like softconn for timeouts Trond Myklebust
2019-03-28 20:52 ` [PATCH 11/25] SUNRPC: Start the first major timeout calculation at task creation Trond Myklebust
2019-03-28 20:52 ` [PATCH 12/25] SUNRPC: Add the 'softerr' rpc_client flag Trond Myklebust
2019-03-28 20:52 ` [PATCH 13/25] NFS: Consider ETIMEDOUT to be a fatal error Trond Myklebust
2019-03-28 20:52 ` [PATCH 14/25] NFS: Move internal constants out of uapi/linux/nfs_mount.h Trond Myklebust
2019-03-28 20:52 ` [PATCH 15/25] NFS: Add a mount option "softerr" to allow clients to see ETIMEDOUT errors Trond Myklebust
2019-03-28 20:52 ` [PATCH 16/25] NFS: Don't interrupt file writeout due to fatal errors Trond Myklebust
2019-03-28 20:52 ` [PATCH 17/25] NFS: Don't call generic_error_remove_page() while holding locks Trond Myklebust
2019-03-28 20:52 ` [PATCH 18/25] NFS: Don't inadvertently clear writeback errors Trond Myklebust
2019-03-28 20:52 ` [PATCH 19/25] NFS: Replace custom error reporting mechanism with generic one Trond Myklebust
2019-03-28 20:52 ` [PATCH 20/25] NFS: Fix up NFS I/O subrequest creation Trond Myklebust
2019-03-28 20:52 ` [PATCH 21/25] NFS: Remove unused argument from nfs_create_request() Trond Myklebust
2019-03-28 20:52 ` [PATCH 22/25] pNFS: Add tracking to limit the number of pNFS retries Trond Myklebust
2019-03-28 20:52 ` [PATCH 23/25] NFS: Allow signal interruption of NFS4ERR_DELAYed operations Trond Myklebust
2019-03-28 20:52 ` [PATCH 24/25] NFS: Add a helper to return a pointer to the open context of a struct nfs_page Trond Myklebust
2019-03-28 20:52 ` [PATCH 25/25] NFS: Remove redundant open context from nfs_page Trond Myklebust
2019-04-01 6:37 ` Dan Carpenter
2019-04-01 6:36 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401063627.GW32613@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild-all@01.org \
--cc=kbuild@01.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox