From: Dave Wysochanski <dwysocha@redhat.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH v2] mountstats: add per-op error counts for mountstats command
Date: Thu, 23 May 2019 16:33:44 -0400 [thread overview]
Message-ID: <20190523203344.12487-1-dwysocha@redhat.com> (raw)
In-Reply-To: <20190523201351.12232-4-dwysocha@redhat.com>
Display the count of ops completing with error status (status < 0)
on kernels that support it.
Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
---
tools/mountstats/mountstats.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
index c7fb8bb1..2f525f4b 100755
--- a/tools/mountstats/mountstats.py
+++ b/tools/mountstats/mountstats.py
@@ -475,7 +475,9 @@ class DeviceData:
retrans = stats[2] - count
if retrans != 0:
print('\t%d retrans (%d%%)' % (retrans, ((retrans * 100) / count)), end=' ')
- print('\t%d major timeouts' % stats[3])
+ print('\t%d major timeouts' % stats[3], end='')
+ if len(stats) >= 10 and stats[9] != 0:
+ print('\t%d errors (%d%%)' % (stats[9], ((stats[9] * 100) / count)))
else:
print('')
print('\tavg bytes sent per op: %d\tavg bytes received per op: %d' % \
--
2.20.1
next prev parent reply other threads:[~2019-05-23 20:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 20:13 [PATCH 1/3] SUNRPC: Move call to rpc_count_iostats before rpc_call_done Dave Wysochanski
2019-05-23 20:13 ` [PATCH 2/3] SUNRPC: Use proper printk specifiers for unsigned long long Dave Wysochanski
2019-05-23 20:13 ` [PATCH 3/3] SUNRPC: Count ops completing with tk_status < 0 Dave Wysochanski
2019-05-30 21:38 ` J. Bruce Fields
2019-05-30 22:19 ` Chuck Lever
2019-05-30 22:33 ` Bruce Fields
2019-05-31 13:25 ` Chuck Lever
2019-06-03 18:53 ` Dave Wysochanski
2019-06-03 18:56 ` Chuck Lever
2019-06-03 19:05 ` Dave Wysochanski
2019-06-03 19:08 ` Chuck Lever
2019-06-04 14:45 ` Bruce Fields
2019-06-04 14:56 ` Trond Myklebust
2019-06-07 14:27 ` Dave Wysochanski
2019-05-31 0:17 ` David Wysochanski
2019-05-23 20:13 ` [PATCH] mountstats: add per-op error counts for mountstats command Dave Wysochanski
2019-05-23 20:33 ` Dave Wysochanski [this message]
2019-06-03 14:31 ` [PATCH v2] " Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523203344.12487-1-dwysocha@redhat.com \
--to=dwysocha@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).