From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB45FC31E5B for ; Mon, 17 Jun 2019 15:32:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A221F20833 for ; Mon, 17 Jun 2019 15:32:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IzYHxRsS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728342AbfFQPcl (ORCPT ); Mon, 17 Jun 2019 11:32:41 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:33110 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725863AbfFQPck (ORCPT ); Mon, 17 Jun 2019 11:32:40 -0400 Received: by mail-io1-f68.google.com with SMTP id u13so22222720iop.0; Mon, 17 Jun 2019 08:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=YseAtOodHX0zGVoGxVns5kTOq1agdmY5wGLUtAbZOJY=; b=IzYHxRsSARcipWc2l29uuedDxKV843x9REU/X2OlrqVKTM1YBGbZOMRSSsIvxzNlNF XWE10EgdYIDfYQ9DQJJkxgyx5nvUQ+J+MeLZKpCbxRk8B9rSANkhaAonzfHEZUtJbBij +lE92gGGhgp728X3GtghnwgykybE4Vu52sDOHOyoNiHwtQGklHs4D17Vuoz7NSgkHhDV 61Kr0cHj7T6HkLKlDrYXLgJapwPuBPYaqmpX4/2BBVQyluhS4x9FrC7KzRPgOlYLhn/b zrsR+t3WQUoAbW0qAuEQju5tQ/6nkzOxXXTlircvUWoXSnaCzcO6amXSzaJkK3NYA6Wy trlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:cc:date:message-id :in-reply-to:references:user-agent:mime-version :content-transfer-encoding; bh=YseAtOodHX0zGVoGxVns5kTOq1agdmY5wGLUtAbZOJY=; b=pgZchAb4UfGUIsBufgmucG/6JGlWEUdJztHtKMPC2O/2g0cOUD6oPVTqJxGJ7Qjw6X 0w9r+hq89w//yV4VW0ttJXBPdy1IfxO2QFvIboaM/nGMgZXzupWpxnZJLg05cyXPuOoJ GQjYp+gbmWXX0hMzVEUZThMoGRvU2TV6C7hwc0hoi0WAiVWbyODrW4yhj0pqum9/HByc OGhT0i6FbrRrWaB2Iwm21CKvriMTdFIn5UdFNv5GjkMCwUBu5Q8q3hptGt9jMQl6EgrE 88ltHi9uKrRND/F9n22pka47UqPTarBeR+jIFtx5zHsw2oJPdh6cQWKhfMNtWouL0SgL MKTQ== X-Gm-Message-State: APjAAAWHWv3m+u0AQ+kxbyfpGtQWGqz9/oQcWUmYoEBaWhcQpgq8m0Fy sAZQz3t1ZRh+ntQnGKcy1No= X-Google-Smtp-Source: APXvYqzzeX+CX16rIei2IaTzzNHAOnNC1GDdOqAidjp5ChQOnr0tbQIgPhQUeDPB7MfYE5UsU/rBQA== X-Received: by 2002:a6b:3883:: with SMTP id f125mr69765339ioa.109.1560785560032; Mon, 17 Jun 2019 08:32:40 -0700 (PDT) Received: from gateway.1015granger.net (c-68-61-232-219.hsd1.mi.comcast.net. [68.61.232.219]) by smtp.gmail.com with ESMTPSA id t4sm9362615ioj.26.2019.06.17.08.32.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 08:32:39 -0700 (PDT) Received: from manet.1015granger.net (manet.1015granger.net [192.168.1.51]) by gateway.1015granger.net (8.14.7/8.14.7) with ESMTP id x5HFWdE6031224; Mon, 17 Jun 2019 15:32:39 GMT Subject: [PATCH v3 13/19] xprtrdma: Remove rpcrdma_req::rl_buffer From: Chuck Lever To: anna.schumaker@netapp.com Cc: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org Date: Mon, 17 Jun 2019 11:32:39 -0400 Message-ID: <20190617153239.12090.64783.stgit@manet.1015granger.net> In-Reply-To: <20190617152657.12090.11389.stgit@manet.1015granger.net> References: <20190617152657.12090.11389.stgit@manet.1015granger.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Clean up. There is only one remaining function, rpcrdma_buffer_put(), that uses this field. Its caller can supply a pointer to the correct rpcrdma_buffer, enabling the removal of an 8-byte pointer field from a frequently-allocated shared data structure. Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/transport.c | 5 ++++- net/sunrpc/xprtrdma/verbs.c | 6 ++---- net/sunrpc/xprtrdma/xprt_rdma.h | 4 ++-- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transport.c index 9575f1d..3688e078 100644 --- a/net/sunrpc/xprtrdma/transport.c +++ b/net/sunrpc/xprtrdma/transport.c @@ -550,8 +550,11 @@ void xprt_rdma_close(struct rpc_xprt *xprt) static void xprt_rdma_free_slot(struct rpc_xprt *xprt, struct rpc_rqst *rqst) { + struct rpcrdma_xprt *r_xprt = + container_of(xprt, struct rpcrdma_xprt, rx_xprt); + memset(rqst, 0, sizeof(*rqst)); - rpcrdma_buffer_put(rpcr_to_rdmar(rqst)); + rpcrdma_buffer_put(&r_xprt->rx_buf, rpcr_to_rdmar(rqst)); rpc_wake_up_next(&xprt->backlog); } diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c index 3270c8a..805b1f35 100644 --- a/net/sunrpc/xprtrdma/verbs.c +++ b/net/sunrpc/xprtrdma/verbs.c @@ -1019,7 +1019,6 @@ struct rpcrdma_req *rpcrdma_req_create(struct rpcrdma_xprt *r_xprt, size_t size, if (!req->rl_recvbuf) goto out4; - req->rl_buffer = buffer; INIT_LIST_HEAD(&req->rl_registered); spin_lock(&buffer->rb_lock); list_add(&req->rl_all, &buffer->rb_allreqs); @@ -1299,13 +1298,12 @@ struct rpcrdma_req * /** * rpcrdma_buffer_put - Put request/reply buffers back into pool + * @buffers: buffer pool * @req: object to return * */ -void -rpcrdma_buffer_put(struct rpcrdma_req *req) +void rpcrdma_buffer_put(struct rpcrdma_buffer *buffers, struct rpcrdma_req *req) { - struct rpcrdma_buffer *buffers = req->rl_buffer; struct rpcrdma_rep *rep = req->rl_reply; req->rl_reply = NULL; diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h index 5475f0d..117e328 100644 --- a/net/sunrpc/xprtrdma/xprt_rdma.h +++ b/net/sunrpc/xprtrdma/xprt_rdma.h @@ -320,7 +320,6 @@ enum { struct rpcrdma_req { struct list_head rl_list; struct rpc_rqst rl_slot; - struct rpcrdma_buffer *rl_buffer; struct rpcrdma_rep *rl_reply; struct xdr_stream rl_stream; struct xdr_buf rl_hdrbuf; @@ -499,7 +498,8 @@ struct rpcrdma_req *rpcrdma_req_create(struct rpcrdma_xprt *r_xprt, size_t size, } struct rpcrdma_req *rpcrdma_buffer_get(struct rpcrdma_buffer *); -void rpcrdma_buffer_put(struct rpcrdma_req *); +void rpcrdma_buffer_put(struct rpcrdma_buffer *buffers, + struct rpcrdma_req *req); void rpcrdma_recv_buffer_put(struct rpcrdma_rep *); bool rpcrdma_regbuf_realloc(struct rpcrdma_regbuf *rb, size_t size,