Re: [PATCH 3/4 RESEND] nfs4: Move nfs4_setup_state_renewal

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2375 bytes --]

Hi Donald,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on nfs/linux-next]
[also build test ERROR on v5.2-rc6 next-20190625]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Donald-Buczek/nfs-Fix-copy-and-paste-error-in-debug-message/20190701-153246
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: arm-sunxi_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   fs//nfs/nfs4state.c: In function 'nfs4_setup_state_renewal':
>> fs//nfs/nfs4state.c:102:11: error: implicit declaration of function 'nfs4_proc_get_lease_time'; did you mean 'nfs4_proc_get_locations'? [-Werror=implicit-function-declaration]
     status = nfs4_proc_get_lease_time(clp, &fsinfo);
              ^~~~~~~~~~~~~~~~~~~~~~~~
              nfs4_proc_get_locations
   At top level:
   fs//nfs/nfs4state.c:90:12: warning: 'nfs4_setup_state_renewal' defined but not used [-Wunused-function]
    static int nfs4_setup_state_renewal(struct nfs_client *clp)
               ^~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +102 fs//nfs/nfs4state.c

    89	
    90	static int nfs4_setup_state_renewal(struct nfs_client *clp)
    91	{
    92		int status;
    93		struct nfs_fsinfo fsinfo;
    94		unsigned long now;
    95	
    96		if (!test_bit(NFS_CS_CHECK_LEASE_TIME, &clp->cl_res_state)) {
    97			nfs4_schedule_state_renewal(clp);
    98			return 0;
    99		}
   100	
   101		now = jiffies;
 > 102		status = nfs4_proc_get_lease_time(clp, &fsinfo);
   103		if (status == 0) {
   104			nfs4_set_lease_period(clp, fsinfo.lease_time * HZ, now);
   105			nfs4_schedule_state_renewal(clp);
   106		}
   107	
   108		return status;
   109	}
   110	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25712 bytes --]