linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
Cc: linux-nfs@vger.kernel.org, Tom Haynes <loghyr@gmail.com>
Subject: Re: [PATCH] st_flex: fix uid/gid formatting in error message
Date: Thu, 1 Aug 2019 16:01:01 -0400	[thread overview]
Message-ID: <20190801200101.GB21527@fieldses.org> (raw)
In-Reply-To: <20190722141602.14274-1-tigran.mkrtchyan@desy.de>

On Mon, Jul 22, 2019 at 04:16:02PM +0200, Tigran Mkrtchyan wrote:
> as ffds_user and ffds_group are utf8 encoded string use '%s' when
> constructing an error message.

Thanks, applied--sorry for being slow to get to this.

--b.

> 
> Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
> ---
>  nfs4.1/server41tests/st_flex.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/nfs4.1/server41tests/st_flex.py b/nfs4.1/server41tests/st_flex.py
> index 335b2c8..f4ac739 100644
> --- a/nfs4.1/server41tests/st_flex.py
> +++ b/nfs4.1/server41tests/st_flex.py
> @@ -313,10 +313,10 @@ def testFlexLayoutTestAccess(t, env):
>      gid_rd = ds.ffds_group
>  
>      if uid_rw == uid_rd:
> -        fail("Expected uid_rd != %i, got %i" % (uid_rd, uid_rw))
> +        fail("Expected uid_rd != %s, got %s" % (uid_rd, uid_rw))
>  
>      if gid_rw != gid_rd:
> -        fail("Expected gid_rd == %i, got %i" % (gid_rd, gid_rw))
> +        fail("Expected gid_rd == %s, got %s" % (gid_rd, gid_rw))
>  
>      res = close_file(sess, fh, stateid=open_stateid)
>      check(res)
> -- 
> 2.21.0

      reply	other threads:[~2019-08-01 20:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-22 14:16 [PATCH] st_flex: fix uid/gid formatting in error message Tigran Mkrtchyan
2019-08-01 20:01 ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190801200101.GB21527@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=loghyr@gmail.com \
    --cc=tigran.mkrtchyan@desy.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).