From: "J. Bruce Fields" <bfields@fieldses.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-nfs@vger.kernel.org,
Anna Schumaker <anna.schumaker@netapp.com>,
Chuck Lever <chuck.lever@oracle.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, Aditya Pakki <pakki001@umn.edu>,
Kangjie Lu <kjlu@umn.edu>, Navid Emamdoost <emamd001@umn.edu>,
Stephen McCamant <smccaman@umn.edu>
Subject: Re: SUNRPC: Checking a kmemdup() call in xdr_netobj_dup()
Date: Mon, 14 Oct 2019 18:33:50 -0400 [thread overview]
Message-ID: <20191014223350.GA19883@fieldses.org> (raw)
In-Reply-To: <9b5a5e63-2a24-ad79-20e2-4c01331ee041@web.de>
On Sat, Oct 12, 2019 at 08:20:04PM +0200, Markus Elfring wrote:
> I tried another script for the semantic patch language out.
> This source code analysis approach points out that the implementation
> of the function “xdr_netobj_dup” contains still an unchecked call
> of the function “kmemdup”.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/sunrpc/xdr.h?id=1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a#n167
> https://elixir.bootlin.com/linux/v5.4-rc2/source/include/linux/sunrpc/xdr.h#L167
>
> How do you think about to improve it?
On a quick check--I see five xdr_netobj_dup callers, and all of them
check whether dst->data is NULL.
Sounds like a false positive for your tool?
--b.
next prev parent reply other threads:[~2019-10-14 22:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 18:20 SUNRPC: Checking a kmemdup() call in xdr_netobj_dup() Markus Elfring
2019-10-14 22:33 ` J. Bruce Fields [this message]
2019-10-15 5:44 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014223350.GA19883@fieldses.org \
--to=bfields@fieldses.org \
--cc=Markus.Elfring@web.de \
--cc=anna.schumaker@netapp.com \
--cc=chuck.lever@oracle.com \
--cc=emamd001@umn.edu \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=pakki001@umn.edu \
--cc=smccaman@umn.edu \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox