From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 123A4ECE588 for ; Tue, 15 Oct 2019 16:31:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D710120872 for ; Tue, 15 Oct 2019 16:31:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="FxFTDNK/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388090AbfJOQbl (ORCPT ); Tue, 15 Oct 2019 12:31:41 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:56704 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388088AbfJOQbl (ORCPT ); Tue, 15 Oct 2019 12:31:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Bz/cXxqXDsLaxH2BJxIVTieueWes3JBGDg9wSSTND6k=; b=FxFTDNK/OR8UcgYmRhV7i2x70 R7r2aOeXeTW5G6BofaO1VRoYa2hhEhB/VEunT2+i44XEtxfgj4GAPR9cXypmBgZpeSyDIjFCGpgSt ESBsOtwIAz55gXaEViAKbl5bOKDQB+aj8knVZuhvcT7MytY9SDniln2NFZaewLFvPKKaZn/LYEeNn 3usCS/A6Ph29jOomZndcbmenJxv4sRW22Vp7JI79/RV8i1PLla+ooMtAN9ceh7xJo0tyMzdz5FMNa gj1afvXfi1oyJCVMfc2JCaTXXSgerrkfnH6+DyGpywJaJaqrkmocqZZ3xtHKf+cN7tskXuf5W9AEF qNmkDZqYA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKPjU-0000Pd-2H; Tue, 15 Oct 2019 16:31:36 +0000 Date: Tue, 15 Oct 2019 09:31:36 -0700 From: Christoph Hellwig To: Ben Dooks Cc: linux-kernel@lists.codethink.co.uk, Trond Myklebust , Anna Schumaker , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] NFSv4: add declaration of current_stateid Message-ID: <20191015163136.GA11160@infradead.org> References: <20191015121953.14905-1-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191015121953.14905-1-ben.dooks@codethink.co.uk> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Tue, Oct 15, 2019 at 01:19:53PM +0100, Ben Dooks wrote: > The current_stateid is exported from nfs4state.c but not > declared in any of the headers. Add to nfs4_fs.h to > remove the following warning: I think you also need to remove the extern in pnfs.c as well. Also nfs4_stateid_is_current has a local variable with the same name, so you might want to rename that so that we don't get symbol shadowing warnings.