Re: [PATCH v2] NFS: allow deprecation of NFS UDP protocol

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3184 bytes --]

Hi Olga,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on nfs/linux-next]
[also build test ERROR on v5.4-rc8 next-20191122]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Olga-Kornievskaia/NFS-allow-deprecation-of-NFS-UDP-protocol/20191124-074905
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: parisc-c3000_defconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   fs/nfs/super.c: In function 'nfs_validate_text_mount_data':
>> fs/nfs/super.c:2209:4: error: label 'out_invalid_transport_udp' used but not defined
       goto out_invalid_transport_udp;
       ^~~~

vim +/out_invalid_transport_udp +2209 fs/nfs/super.c

  2174	
  2175	static int nfs_validate_text_mount_data(void *options,
  2176						struct nfs_parsed_mount_data *args,
  2177						const char *dev_name)
  2178	{
  2179		int port = 0;
  2180		int max_namelen = PAGE_SIZE;
  2181		int max_pathlen = NFS_MAXPATHLEN;
  2182		struct sockaddr *sap = (struct sockaddr *)&args->nfs_server.address;
  2183	
  2184		if (nfs_parse_mount_options((char *)options, args) == 0)
  2185			return -EINVAL;
  2186	
  2187		if (!nfs_verify_server_address(sap))
  2188			goto out_no_address;
  2189	
  2190		if (args->version == 4) {
  2191	#if IS_ENABLED(CONFIG_NFS_V4)
  2192			if (args->nfs_server.protocol == XPRT_TRANSPORT_RDMA)
  2193				port = NFS_RDMA_PORT;
  2194			else
  2195				port = NFS_PORT;
  2196			max_namelen = NFS4_MAXNAMLEN;
  2197			max_pathlen = NFS4_MAXPATHLEN;
  2198			nfs_validate_transport_protocol(args);
  2199			if (args->nfs_server.protocol == XPRT_TRANSPORT_UDP)
  2200				goto out_invalid_transport_udp;
  2201			nfs4_validate_mount_flags(args);
  2202	#else
  2203			goto out_v4_not_compiled;
  2204	#endif /* CONFIG_NFS_V4 */
  2205		} else {
  2206			nfs_set_mount_transport_protocol(args);
  2207	#ifdef CONFIG_NFS_DISABLE_UDP_SUPPORT
  2208			if (args->nfs_server.protocol == XPRT_TRANSPORT_UDP)
> 2209				goto out_invalid_transport_udp;
  2210	#endif
  2211			if (args->nfs_server.protocol == XPRT_TRANSPORT_RDMA)
  2212				port = NFS_RDMA_PORT;
  2213		}
  2214	
  2215		nfs_set_port(sap, &args->nfs_server.port, port);
  2216	
  2217		return nfs_parse_devname(dev_name,
  2218					   &args->nfs_server.hostname,
  2219					   max_namelen,
  2220					   &args->nfs_server.export_path,
  2221					   max_pathlen);
  2222	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 15688 bytes --]