From: bfields@fieldses.org (J. Bruce Fields)
To: fstests@vger.kernel.org
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH] generic/529: use an ACL that doesn't confuse NFS
Date: Thu, 19 Dec 2019 17:33:36 -0500 [thread overview]
Message-ID: <20191219223336.GC12026@fieldses.org> (raw)
From: "J. Bruce Fields" <bfields@redhat.com>
For historical reasons having to do with Solaris ACL behavior, the Linux
client treats an ACL like the one used as an example here as equivalent
to a mode, causing listxattr to report that no ACL is set on the file.
(See the comment at the top of fs/nfs_common/nfsacl.c in the kernel
source for details, and the "bogus ACL_MASK entry" comment in the same
source file.) This causes a spurious generic/529 failure on NFS.
As far as I can tell any ACL should trigger the original XFS problem.
So, modify it so as not to hit this odd NFS corner case.
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
src/t_attr_corruption.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/t_attr_corruption.c b/src/t_attr_corruption.c
index e7d435b1791f..b5513d44a288 100644
--- a/src/t_attr_corruption.c
+++ b/src/t_attr_corruption.c
@@ -59,7 +59,7 @@ int main(int argc, char *argv[])
.e = {
{htole16(1), 0, 0},
{htole16(4), 0, 0},
- {htole16(0x10), 0, 0},
+ {htole16(0x10), htole16(4), 0},
{htole16(0x20), 0, 0},
},
};
--
2.24.1
next reply other threads:[~2019-12-19 22:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 22:33 J. Bruce Fields [this message]
2020-01-07 11:41 ` [PATCH] generic/529: use an ACL that doesn't confuse NFS Murphy Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219223336.GC12026@fieldses.org \
--to=bfields@fieldses.org \
--cc=fstests@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox