Re: [PATCH 00/13] client side user xattr (RFC8276) support

Frank van der Linden
2020-03-17T23:03:55Z

On Thu, Mar 12, 2020 at 04:09:51PM -0400, Anna Schumaker wrote:
> I'm curious if you've tried xfstests with your patches? There are a
> handful of tests using xattrs that might be good to check with, too:
>
> anna@gouda % grep xattr -l tests/generic/[0-9][0-9][0-9]
> tests/generic/037
> tests/generic/062
> tests/generic/066
> tests/generic/093
> tests/generic/117
> tests/generic/337
> tests/generic/377
> tests/generic/403
> tests/generic/425
> tests/generic/454
> tests/generic/489
> tests/generic/523
> tests/generic/529
> tests/generic/556
>
> Thanks,
> Anna

I ran did a "check -nfs -g quick" run of xfstests-dev. The following tests
were applicable to extended attributes:

generic/020 fail Doesn't compute MAX_ATTR right for NFS, passes
after fixing that.
generic/037 pass
generic/062 fail It unconditionally expects the "system" and
"trusted" namespaces to be there too, not
easily fixed.
generic/066 pass
generic/093 fail Capabilities use the "security" namespace, can't
work on NFS.
generic/097 fail "trusted" namespace explicitly used, can't work
on NFS.
generic/103 fail fallocate fails on NFS, not xattr related
generic/117 pass
generic/377 fail Doesn't expect the "system.nfs4acl" attribute to
show up in listxattr. Can be fixed by filtering
out only "user" namespace xattrs.
generic/403 fail Uses the "trusted" namespace, but does not really
need it. Works if converted to the "user" namespace.
generic/454 pass
generic/523 pass

In other words, there were no problems with the patches themselves, but
xfstests will need some work to work properly.

I can send a few simple fixes in for xfstests, but a few need a bit more
work, specifically the ones that expected certain xattr namespaces to be
there. Right now there is a "_require_attr" check function, that probably
needs to be split up in to "_require_attr_user, _require_attr_system", etc
functions, which is a bit more work.

- Frank