Re: [PATCH 11/14] nfsd: add user xattr RPC XDR encoding/decoding logic

J. Bruce Fields
2020-03-20T17:55:06Z

On Fri, Mar 20, 2020 at 01:34:53PM -0400, Chuck Lever wrote:
>
>
> > On Mar 20, 2020, at 12:47 PM, Frank van der Linden <fllinden@amazon.com> wrote:
> > There definitely seem to be several copy functions in both the client
> > and server code that basically do the same, but in slightly different ways,
> > depending on whether they use an XDR buf or not, whether the pages are
> > mapped or not, etc. Seems like a good candidate for a cleanup, but I
> > considered it to be out of scope for these patches.
>
> "out of scope" - probably so. Depending on Bruce's thinking, we can
> add this to the list of janitorial tasks.

The rewrite of the server xdr encoding was... oh jeez, six years ago
now, and I haven't really thought about it since. I remember thinking
we should do the decode side as well someday, though, and thinking it
should be pretty doable.

--b.