public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Bruce Fields <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Trond Myklebust <trond.myklebust@hammerspace.com>,
	NeilBrown <neilb@suse.com>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
	Yihao Wu <wuyihao@linux.alibaba.com>
Subject: Re: [PATCH] nfsd: fix race between cache_clean and cache_purge
Date: Tue, 24 Mar 2020 10:33:56 -0400	[thread overview]
Message-ID: <20200324143356.GA11065@fieldses.org> (raw)
In-Reply-To: <8B2BC124-6911-46C9-9B01-A237AC149F0A@oracle.com>

On Tue, Mar 24, 2020 at 09:38:55AM -0400, Chuck Lever wrote:
> Mechanically this looks OK, but I would feel more comfortable
> if a domain expert could review this. Neil, Trond, Bruce?

Looks right to me.

Reviewed-by: J. Bruce Fields <bfields@redhat.com>

--b.

  reply	other threads:[~2020-03-24 14:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-24  9:49 [PATCH] nfsd: fix race between cache_clean and cache_purge Yihao Wu
2020-03-24 13:38 ` Chuck Lever
2020-03-24 14:33   ` Bruce Fields [this message]
2020-03-24 14:35     ` Chuck Lever
2020-03-24 15:24   ` Trond Myklebust
2020-03-24 17:46     ` Chuck Lever
2020-03-25  6:37       ` Yihao Wu
2020-03-25 14:24         ` Chuck Lever
2020-03-25 15:14           ` Yihao Wu
2020-03-24 14:18 ` Chuck Lever
2020-03-24 14:28   ` Yihao Wu
2020-03-24 23:07 ` NeilBrown
2020-04-04 13:53   ` Yihao Wu
2020-03-25  1:01 ` Sasha Levin
2020-03-25 14:13   ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200324143356.GA11065@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.com \
    --cc=trond.myklebust@hammerspace.com \
    --cc=wuyihao@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox