From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9D8DC2BA19 for ; Tue, 14 Apr 2020 16:17:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 885BC20678 for ; Tue, 14 Apr 2020 16:17:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390951AbgDNQRr (ORCPT ); Tue, 14 Apr 2020 12:17:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1733258AbgDNQRo (ORCPT ); Tue, 14 Apr 2020 12:17:44 -0400 X-Greylist: delayed 3880 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 14 Apr 2020 09:17:44 PDT Received: from fieldses.org (fieldses.org [IPv6:2600:3c00::f03c:91ff:fe50:41d6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5CDEC061A0C; Tue, 14 Apr 2020 09:17:44 -0700 (PDT) Received: by fieldses.org (Postfix, from userid 2815) id 4AA271C7A; Tue, 14 Apr 2020 12:17:44 -0400 (EDT) Date: Tue, 14 Apr 2020 12:17:44 -0400 From: "J. Bruce Fields" To: Jason Gunthorpe Cc: Chuck Lever , Leon Romanovsky , Linux NFS Mailing List , linux-rdma@vger.kernel.org Subject: Re: [PATCH v1 3/3] svcrdma: Fix leak of svc_rdma_recv_ctxt objects Message-ID: <20200414161744.GB9796@fieldses.org> References: <20200407190938.24045.64947.stgit@klimt.1015granger.net> <20200407191106.24045.88035.stgit@klimt.1015granger.net> <20200408060242.GB3310@unreal> <20200409174750.GK11886@ziepe.ca> <20200413192907.GA23596@fieldses.org> <20200414121931.GA5100@ziepe.ca> <20200414151303.GA9796@fieldses.org> <20200414152016.GE5100@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200414152016.GE5100@ziepe.ca> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Tue, Apr 14, 2020 at 12:20:16PM -0300, Jason Gunthorpe wrote: > On Tue, Apr 14, 2020 at 11:13:03AM -0400, J. Bruce Fields wrote: > > On Tue, Apr 14, 2020 at 09:19:31AM -0300, Jason Gunthorpe wrote: > > > On Mon, Apr 13, 2020 at 03:29:07PM -0400, J. Bruce Fields wrote: > > > > On Thu, Apr 09, 2020 at 02:47:50PM -0300, Jason Gunthorpe wrote: > > > > > On Thu, Apr 09, 2020 at 10:33:32AM -0400, Chuck Lever wrote: > > > > > > The commit ID is what automation should key off of. The short > > > > > > description is only for human consumption. > > > > > > > > > > Right, so if the actual commit message isn't included so humans can > > > > > read it then what was the point of including anything? > > > > > > > > Personally as a human reading commits in a terminal window I prefer the > > > > abbreviated form. > > > > > > Frankly, I think they are useless, picking one of yours at random: > > > > > > Fixes: 4e48f1cccab3 "NFSD: allow inter server COPY to have... " > > > > > > And sadly the '4e48f1cccab3' commit doesn't appear in Linus's tree so > > > > Ow, apologies. Looks like I rebased after writing that Fixes tag. > > > > I wonder if it's possible to make git warn.... > > > > Looks like a pre-rebase hook could check the branch being rebased for > > "Fixes:" lines referencing commits on the rebased branch. > > I have some silly stuff to check patches before pushing them and it > includes checking the fixes lines because they are very often > wrong, both with wrong commit IDs and wrong subjects! I'd be interested in seeing it. > linux-next now automates complaining about them, but perhaps not > following the standard format defeats that.. It's managed before: https://lore.kernel.org/r/20190704074048.65556740@canb.auug.org.au though admittedly I was breaking the rule in a different way. I can't even be consistently rebellious. > Use 'git merge-base --is-ancestor fixes_id linus/master' to check > them. Oh, yeah, that's better than what I was trying to do, thanks. --b.