Re: [PATCH v1 3/3] svcrdma: Fix leak of svc_rdma_recv_ctxt objects

Jason Gunthorpe
2020-04-14T12:19:43Z

On Mon, Apr 13, 2020 at 03:29:07PM -0400, J. Bruce Fields wrote:
> On Thu, Apr 09, 2020 at 02:47:50PM -0300, Jason Gunthorpe wrote:
> > On Thu, Apr 09, 2020 at 10:33:32AM -0400, Chuck Lever wrote:
> > > The commit ID is what automation should key off of. The short
> > > description is only for human consumption.
> >
> > Right, so if the actual commit message isn't included so humans can
> > read it then what was the point of including anything?
>
> Personally as a human reading commits in a terminal window I prefer the
> abbreviated form.

Frankly, I think they are useless, picking one of yours at random:

Fixes: 4e48f1cccab3 "NFSD: allow inter server COPY to have... "

And sadly the '4e48f1cccab3' commit doesn't appear in Linus's tree so
now we are just totally lost, with a bad commit ID and a mangled
subject line.

> I haven't been doing the redundant parentheses and quotes either. Was
> that dreamt up by an Arlo Guthrie fan? ("KID, HAVE YOU REHABILITATED
> YOURSELF?")

Well it seems like you are just aren't following the standard style
at all. :(

Jason