From: trondmy@kernel.org
To: Steve Dickson <SteveD@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 1/7] mountd: Add a helper nfsd_path_statfs64() for uuid_by_path()
Date: Thu, 16 Apr 2020 18:12:46 -0400 [thread overview]
Message-ID: <20200416221252.82102-2-trondmy@kernel.org> (raw)
In-Reply-To: <20200416221252.82102-1-trondmy@kernel.org>
From: Trond Myklebust <trond.myklebust@hammerspace.com>
Ensure uuid_by_path() works correctly when 'rootdir'
is set in the [exports] section of nfs.conf.
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
---
support/include/nfsd_path.h | 5 +++++
support/misc/nfsd_path.c | 43 +++++++++++++++++++++++++++++++++++++
utils/mountd/cache.c | 2 +-
3 files changed, 49 insertions(+), 1 deletion(-)
diff --git a/support/include/nfsd_path.h b/support/include/nfsd_path.h
index b42416bbff58..8331ff96a277 100644
--- a/support/include/nfsd_path.h
+++ b/support/include/nfsd_path.h
@@ -6,6 +6,8 @@
#include <sys/stat.h>
+struct statfs64;
+
void nfsd_path_init(void);
const char * nfsd_path_nfsd_rootdir(void);
@@ -15,6 +17,9 @@ char * nfsd_path_prepend_dir(const char *dir, const char *pathname);
int nfsd_path_stat(const char *pathname, struct stat *statbuf);
int nfsd_path_lstat(const char *pathname, struct stat *statbuf);
+int nfsd_path_statfs64(const char *pathname,
+ struct statfs64 *statbuf);
+
char * nfsd_realpath(const char *path, char *resolved_path);
ssize_t nfsd_path_read(int fd, char *buf, size_t len);
diff --git a/support/misc/nfsd_path.c b/support/misc/nfsd_path.c
index f078a668fb8f..ab6c98dbe395 100644
--- a/support/misc/nfsd_path.c
+++ b/support/misc/nfsd_path.c
@@ -5,6 +5,7 @@
#include <errno.h>
#include <sys/types.h>
#include <sys/stat.h>
+#include <sys/vfs.h>
#include <limits.h>
#include <stdlib.h>
#include <unistd.h>
@@ -180,6 +181,48 @@ nfsd_path_lstat(const char *pathname, struct stat *statbuf)
return nfsd_run_stat(nfsd_wq, nfsd_lstatfunc, pathname, statbuf);
}
+struct nfsd_statfs64_data {
+ const char *pathname;
+ struct statfs64 *statbuf;
+ int ret;
+ int err;
+};
+
+static void
+nfsd_statfs64func(void *data)
+{
+ struct nfsd_statfs64_data *d = data;
+
+ d->ret = statfs64(d->pathname, d->statbuf);
+ if (d->ret < 0)
+ d->err = errno;
+}
+
+static int
+nfsd_run_statfs64(struct xthread_workqueue *wq,
+ const char *pathname,
+ struct statfs64 *statbuf)
+{
+ struct nfsd_statfs64_data data = {
+ pathname,
+ statbuf,
+ 0,
+ 0
+ };
+ xthread_work_run_sync(wq, nfsd_statfs64func, &data);
+ if (data.ret < 0)
+ errno = data.err;
+ return data.ret;
+}
+
+int
+nfsd_path_statfs64(const char *pathname, struct statfs64 *statbuf)
+{
+ if (!nfsd_wq)
+ return statfs64(pathname, statbuf);
+ return nfsd_run_statfs64(nfsd_wq, pathname, statbuf);
+}
+
struct nfsd_realpath_data {
const char *pathname;
char *resolved;
diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
index 8f54e37b7936..7d8657c91323 100644
--- a/utils/mountd/cache.c
+++ b/utils/mountd/cache.c
@@ -352,7 +352,7 @@ static int uuid_by_path(char *path, int type, size_t uuidlen, char *uuid)
const char *val;
int rc;
- rc = statfs64(path, &st);
+ rc = nfsd_path_statfs64(path, &st);
if (type == 0 && rc == 0) {
const unsigned long *bad;
--
2.25.2
next prev parent reply other threads:[~2020-04-16 22:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 22:12 [PATCH 0/7] nfs-utils fixes trondmy
2020-04-16 22:12 ` trondmy [this message]
2020-04-16 22:12 ` [PATCH 2/7] nfsd: Support running nfsd_name_to_handle_at() in the root jail trondmy
2020-04-16 22:12 ` [PATCH 3/7] mountd: Fix up path checking helper same_path() trondmy
2020-04-16 22:12 ` [PATCH 4/7] Fix autoconf probe for 'struct nfs_filehandle' trondmy
2020-04-16 22:12 ` [PATCH 5/7] mountd: Ensure dump_to_cache() sets errno appropriately trondmy
2020-04-16 22:12 ` [PATCH 6/7] mountd: Ignore transient and non-fatal filesystem errors in nfsd_fh() trondmy
2020-04-16 22:12 ` [PATCH 7/7] mountd: Check the stat() return values in match_fsid() trondmy
2020-04-27 18:38 ` [PATCH 6/7] mountd: Ignore transient and non-fatal filesystem errors in nfsd_fh() J. Bruce Fields
2020-04-27 18:39 ` J. Bruce Fields
2020-05-08 14:13 ` [PATCH 0/7] nfs-utils fixes Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416221252.82102-2-trondmy@kernel.org \
--to=trondmy@kernel.org \
--cc=SteveD@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).