From: Dan Carpenter <dan.carpenter@oracle.com>
To: Trond Myklebust <trond.myklebust@hammerspace.com>,
Frank van der Linden <fllinden@amazon.com>
Cc: Anna Schumaker <anna.schumaker@netapp.com>,
linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] NFSv4.2: Fix an error code in nfs4_xattr_cache_init()
Date: Mon, 27 Jul 2020 14:23:44 +0300 [thread overview]
Message-ID: <20200727112344.GH389488@mwanda> (raw)
This should return -ENOMEM on failure instead of success.
Fixes: 95ad37f90c33 ("NFSv4.2: add client side xattr caching.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
---
fs/nfs/nfs42xattr.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/nfs/nfs42xattr.c b/fs/nfs/nfs42xattr.c
index 23fdab977a2a..e75c4bb70266 100644
--- a/fs/nfs/nfs42xattr.c
+++ b/fs/nfs/nfs42xattr.c
@@ -1040,8 +1040,10 @@ int __init nfs4_xattr_cache_init(void)
goto out2;
nfs4_xattr_cache_wq = alloc_workqueue("nfs4_xattr", WQ_MEM_RECLAIM, 0);
- if (nfs4_xattr_cache_wq == NULL)
+ if (nfs4_xattr_cache_wq == NULL) {
+ ret = -ENOMEM;
goto out1;
+ }
ret = register_shrinker(&nfs4_xattr_cache_shrinker);
if (ret)
--
2.27.0
next reply other threads:[~2020-07-27 11:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 11:23 Dan Carpenter [this message]
2020-07-27 16:34 ` [PATCH] NFSv4.2: Fix an error code in nfs4_xattr_cache_init() Frank van der Linden
2020-07-28 15:17 ` Trond Myklebust
2020-07-28 16:09 ` Frank van der Linden
2020-07-28 17:10 ` Trond Myklebust
2020-07-28 18:00 ` Frank van der Linden
2020-07-28 18:04 ` Trond Myklebust
2020-07-28 18:13 ` Frank van der Linden
2020-07-28 18:21 ` Trond Myklebust
2020-07-28 20:18 ` Frank van der Linden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727112344.GH389488@mwanda \
--to=dan.carpenter@oracle.com \
--cc=anna.schumaker@netapp.com \
--cc=fllinden@amazon.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox