From: Bruce Fields <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Bill Baker <Bill.Baker@oracle.com>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v2 00/27] NFSD operation monitoring tracepoints
Date: Fri, 25 Sep 2020 14:37:17 -0400 [thread overview]
Message-ID: <20200925183717.GG1096@fieldses.org> (raw)
In-Reply-To: <551339D6-2109-487D-8279-746BCA106893@oracle.com>
On Fri, Sep 25, 2020 at 01:04:55PM -0400, Chuck Lever wrote:
> > On Sep 25, 2020, at 11:05 AM, Chuck Lever <chuck.lever@oracle.com> wrote:
> >> On Sep 25, 2020, at 11:00 AM, Bruce Fields <bfields@fieldses.org> wrote:
> >> On Fri, Sep 25, 2020 at 10:36:42AM -0400, Chuck Lever wrote:
> >>>> One thing I was wondering about: how would you limit tracing to a single
> >>>> client, say if you wanted to see all DELEGRETURNs from a single client?
> >>>> I guess you'd probably turn on a tracepoint in the receive code, look
> >>>> for your client's IP address, then mask the task id to match later
> >>>> nfs-level tracepoints. Is there enough information in those tracepoints
> >>>> (including network namespace) to uniquely identify a client?
> >>>
> >>> Client IP address information is in the RPC layer trace data. The
> >>> DELEGRETURN trace record includes client ID. So maybe not as
> >>> straightforward as it could be.
> >>
> >> I guess what I meant was "limit tracing to a single network endpoint",
> >> not exactly limt to a single NFSv4 client.... So, we can do that as
> >> long as all the relevant information is in rpc-layer tracepoints, and as
> >> long as task id is a reliable way to match up trace points.
> >>
> >> Is the network namespace in there anywhere? It looks like there'd be no
> >> way to distinguish clients in different namespaces if they had the same
> >> address.
> >
> > The client ID has the boot verifier for the net namespace.
> >
> > None of this helps NFSv3, though.
>
> It probably wouldn't be difficult to stuff the client IP address
> and the boot verifier in the trace record for each procedure.
>
> Do you think that would be sufficient?
Despite using 64 bits the boot verifier isn't even guaranteed to
uniquely identify a network namespace. There should be something
better. Digging around.... ns->inum, I think?
I don't know if it (or ports or addresses) needs to be in every trace
record. Maybe just once somewhere in one of the rpc layer tracepoints,
and then we can use the nfsd task id to connect it with other
tracepoints if necessary. Does that make sense?
--b.
next prev parent reply other threads:[~2020-09-25 18:37 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 18:10 [PATCH v2 00/27] NFSD operation monitoring tracepoints Chuck Lever
2020-09-21 18:10 ` [PATCH v2 01/27] NFS: Move generic FS show macros to global header Chuck Lever
2020-09-21 18:11 ` [PATCH v2 02/27] NFS: Move NFS protocol display " Chuck Lever
2020-09-21 18:11 ` [PATCH v2 03/27] NFSD: Add SPDX header for fs/nfsd/trace.c Chuck Lever
2020-09-21 18:11 ` [PATCH v2 04/27] SUNRPC: Move the svc_xdr_recvfrom() tracepoint Chuck Lever
2020-09-21 18:11 ` [PATCH v2 05/27] SUNRPC: Add svc_xdr_authenticate tracepoint Chuck Lever
2020-09-21 18:11 ` [PATCH v2 06/27] lockd: Replace PROC() macro with open code Chuck Lever
2020-09-21 18:11 ` [PATCH v2 07/27] NFSACL: " Chuck Lever
2020-09-21 18:11 ` [PATCH v2 08/27] SUNRPC: Make trace_svc_process() display the RPC procedure symbolically Chuck Lever
2020-09-21 18:11 ` [PATCH v2 09/27] NFSD: Clean up the show_nf_may macro Chuck Lever
2020-09-21 18:11 ` [PATCH v2 10/27] NFSD: Remove extra "0x" in tracepoint format specifier Chuck Lever
2020-09-21 18:11 ` [PATCH v2 11/27] NFSD: Constify @fh argument of knfsd_fh_hash() Chuck Lever
2020-09-21 18:11 ` [PATCH v2 12/27] NFSD: Add tracepoint in nfsd_setattr() Chuck Lever
2020-09-21 18:11 ` [PATCH v2 13/27] NFSD: Add tracepoint for nfsd_access() Chuck Lever
2020-09-21 18:12 ` [PATCH v2 14/27] NFSD: nfsd_compound_status tracepoint should record XID Chuck Lever
2020-09-21 18:12 ` [PATCH v2 15/27] NFSD: Add client ID lifetime tracepoints Chuck Lever
2020-09-21 18:12 ` [PATCH v2 16/27] NFSD: Add tracepoints to report NFSv4 session state Chuck Lever
2020-09-21 18:12 ` [PATCH v2 17/27] NFSD: Add a tracepoint to report the current filehandle Chuck Lever
2020-09-21 18:12 ` [PATCH v2 18/27] NFSD: Add GETATTR tracepoint Chuck Lever
2020-09-21 18:12 ` [PATCH v2 19/27] NFSD: Add tracepoint in nfsd4_stateid_preprocess() Chuck Lever
2020-09-21 18:12 ` [PATCH v2 20/27] NFSD: Add tracepoint to report arguments to NFSv4 OPEN Chuck Lever
2020-09-21 18:12 ` [PATCH v2 21/27] NFSD: Add a tracepoint for DELEGRETURN Chuck Lever
2020-09-21 18:12 ` [PATCH v2 22/27] NFSD: Add a lookup tracepoint Chuck Lever
2020-09-21 18:12 ` [PATCH v2 23/27] NFSD: Add lock and locku tracepoints Chuck Lever
2020-09-21 18:12 ` [PATCH v2 24/27] NFSD: Add tracepoints to record the result of TEST_STATEID and FREE_STATEID Chuck Lever
2020-09-21 18:13 ` [PATCH v2 25/27] NFSD: Rename nfsd_ tracepoints to nfsd4_ Chuck Lever
2020-09-21 18:13 ` [PATCH v2 26/27] NFSD: Add tracepoints in the NFS dispatcher Chuck Lever
2020-09-24 23:45 ` J. Bruce Fields
2020-09-25 13:59 ` Chuck Lever
2020-09-25 14:17 ` Bruce Fields
2020-09-25 14:21 ` Chuck Lever
2020-09-25 14:18 ` Chuck Lever
2020-09-25 14:47 ` Bruce Fields
2020-09-21 18:13 ` [PATCH v2 27/27] NFSD: Replace dprintk callsites in fs/nfsd/nfsfh.c Chuck Lever
2020-09-24 21:36 ` [PATCH v2 00/27] NFSD operation monitoring tracepoints J. Bruce Fields
2020-09-25 13:59 ` Chuck Lever
2020-09-25 14:32 ` Bruce Fields
2020-09-25 14:36 ` Chuck Lever
2020-09-25 15:00 ` Bruce Fields
2020-09-25 15:05 ` Chuck Lever
2020-09-25 17:04 ` Chuck Lever
2020-09-25 18:37 ` Bruce Fields [this message]
2020-09-25 18:41 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925183717.GG1096@fieldses.org \
--to=bfields@fieldses.org \
--cc=Bill.Baker@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).