Re: [PATCH 2/2] NFSv4: Use the net namespace uniquifier if it is set

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2673 bytes --]

Hi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on nfs/linux-next]
[also build test WARNING on v5.9-rc8 next-20201007]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/trondmy-kernel-org/Give-containers-a-unique-client-id/20201008-050958
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: s390-randconfig-s032-20201008 (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.2-218-gc0e96d6d-dirty
        # https://github.com/0day-ci/linux/commit/440cb74f8b835271bd5e1f6574dc9cb002cec5be
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review trondmy-kernel-org/Give-containers-a-unique-client-id/20201008-050958
        git checkout 440cb74f8b835271bd5e1f6574dc9cb002cec5be
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

echo
echo "sparse warnings: (new ones prefixed by >>)"
echo
>> fs/nfs/nfs4proc.c:6022:22: sparse: sparse: incompatible types in comparison expression (different address spaces):
>> fs/nfs/nfs4proc.c:6022:22: sparse:    char const [noderef] __rcu *
>> fs/nfs/nfs4proc.c:6022:22: sparse:    char const *

vim +6022 fs/nfs/nfs4proc.c

  6009	
  6010	static size_t
  6011	nfs4_get_uniquifier(struct nfs_client *clp, char *buf, size_t buflen)
  6012	{
  6013		struct nfs_net *nn = net_generic(clp->cl_net, nfs_net_id);
  6014		struct nfs_netns_client *nn_clp = nn->nfs_client;
  6015		const char *id;
  6016		size_t len;
  6017	
  6018		buf[0] = '\0';
  6019	
  6020		if (nn_clp) {
  6021			rcu_read_lock();
> 6022			id = rcu_dereference(nn_clp->identifier);
  6023			if (id && *id != '\0')
  6024				len = strlcpy(buf, id, buflen);
  6025			rcu_read_unlock();
  6026			if (len)
  6027				return len;
  6028		}
  6029	
  6030		if (nfs4_client_id_uniquifier[0] != '\0')
  6031			return strlcpy(buf, nfs4_client_id_uniquifier, buflen);
  6032		return 0;
  6033	}
  6034	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 20942 bytes --]