From: "J. Bruce Fields" <bfields@fieldses.org>
To: trix@redhat.com
Cc: chuck.lever@oracle.com, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfsd: remove unneeded break
Date: Mon, 12 Oct 2020 10:19:38 -0400 [thread overview]
Message-ID: <20201012141938.GC26571@fieldses.org> (raw)
In-Reply-To: <20201011155155.15538-1-trix@redhat.com>
On Sun, Oct 11, 2020 at 08:51:55AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Because every path through nfs4_find_file()'s
> switch does an explicit return, the break is not needed.
OK, applying.--b.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> fs/nfsd/nfs4state.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index c09a2a4281ec..741f64672d96 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -5722,7 +5722,6 @@ nfs4_find_file(struct nfs4_stid *s, int flags)
> return find_readable_file(s->sc_file);
> else
> return find_writeable_file(s->sc_file);
> - break;
> }
>
> return NULL;
> --
> 2.18.1
prev parent reply other threads:[~2020-10-12 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 15:51 [PATCH] nfsd: remove unneeded break trix
2020-10-12 14:19 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012141938.GC26571@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).