From: "J. Bruce Fields" <bfields@fieldses.org>
To: Dai Ngo <dai.ngo@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 0/2] NFSD: Fix use-after-free warning when doing inter-server copy
Date: Thu, 5 Nov 2020 17:25:34 -0500 [thread overview]
Message-ID: <20201105222534.GG25512@fieldses.org> (raw)
In-Reply-To: <20201029190716.70481-1-dai.ngo@oracle.com>
Applying for 5.10, thanks!
--b.
On Thu, Oct 29, 2020 at 03:07:14PM -0400, Dai Ngo wrote:
> Observed use-after-free messages in /var/log/messages of destination
> server when doing inter-server copy. These come from 2 different places
> in the code, one from the nfsd4_cleanup_inter_ssc when nfsd_file_put
> is called for the source file and the other from nfs4_put_copy when
> it's called from nfsd4_cb_offload_release.
>
> Fixed by removing the call to nfsd_file_put; the object is not allocated
> by nfsd_file_alloc, and by initializing refcount for nfsd4_copy in
> nfsd4_do_async_copy.
>
> fs/nfsd/nfs4proc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
prev parent reply other threads:[~2020-11-05 22:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 19:07 [PATCH 0/2] NFSD: Fix use-after-free warning when doing inter-server copy Dai Ngo
2020-10-29 19:07 ` [PATCH 1/2] " Dai Ngo
2021-02-20 0:18 ` Olga Kornievskaia
2021-02-20 1:09 ` J. Bruce Fields
2021-02-20 1:15 ` dai.ngo
2021-02-20 1:31 ` dai.ngo
2021-02-20 3:20 ` J. Bruce Fields
2021-02-20 3:41 ` dai.ngo
2021-02-20 14:08 ` Olga Kornievskaia
2021-02-21 4:16 ` dai.ngo
2021-02-22 18:34 ` dai.ngo
2021-02-22 21:46 ` dai.ngo
2021-02-22 22:01 ` dai.ngo
2021-02-22 22:08 ` dai.ngo
2021-02-24 22:35 ` Olga Kornievskaia
2021-02-25 2:26 ` dai.ngo
2021-02-25 18:58 ` dai.ngo
2021-03-01 18:15 ` Chuck Lever
2020-10-29 19:07 ` [PATCH 2/2] NFSD: fix missing refcount in nfsd4_copy by nfsd4_do_async_copy Dai Ngo
2020-11-05 22:25 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105222534.GG25512@fieldses.org \
--to=bfields@fieldses.org \
--cc=dai.ngo@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox