From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFSD: NFSv3 PATHCONF Reply is improperly formed
Date: Fri, 6 Nov 2020 17:27:54 -0500 [thread overview]
Message-ID: <20201106222754.GF26028@fieldses.org> (raw)
In-Reply-To: <160346406185.79082.5918603581435378646.stgit@klimt.1015granger.net>
Applied, thanks.--b.
On Fri, Oct 23, 2020 at 10:41:01AM -0400, Chuck Lever wrote:
> Commit cc028a10a48c ("NFSD: Hoist status code encoding into XDR
> encoder functions") missed a spot.
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> fs/nfsd/nfs3xdr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/nfsd/nfs3xdr.c b/fs/nfsd/nfs3xdr.c
> index 9c23b6acf234..2277f83da250 100644
> --- a/fs/nfsd/nfs3xdr.c
> +++ b/fs/nfsd/nfs3xdr.c
> @@ -1114,6 +1114,7 @@ nfs3svc_encode_pathconfres(struct svc_rqst *rqstp, __be32 *p)
> {
> struct nfsd3_pathconfres *resp = rqstp->rq_resp;
>
> + *p++ = resp->status;
> *p++ = xdr_zero; /* no post_op_attr */
>
> if (resp->status == 0) {
>
prev parent reply other threads:[~2020-11-06 22:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 14:41 [PATCH] NFSD: NFSv3 PATHCONF Reply is improperly formed Chuck Lever
2020-11-06 22:27 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106222754.GF26028@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox