From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EE96C8300F for ; Tue, 1 Dec 2020 04:15:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE4B920725 for ; Tue, 1 Dec 2020 04:15:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="CNqIfZq7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728173AbgLAEPK (ORCPT ); Mon, 30 Nov 2020 23:15:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:60320 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728074AbgLAEPJ (ORCPT ); Mon, 30 Nov 2020 23:15:09 -0500 Received: from leira.hammer.space (c-68-36-133-222.hsd1.mi.comcast.net [68.36.133.222]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C2FF32073C; Tue, 1 Dec 2020 04:14:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606796069; bh=WkRXVMGuVl3KYYtb+GbOribXJZ0BvJN+p50CbCiAzfM=; h=From:To:Cc:Subject:Date:From; b=CNqIfZq770+lMlzdEkMUP9DT1lorXp0NXVAxLcYlUU96jbCoX1ngtH0tL0Ak1e/MR JHK31qYU/aBH966+84OW8nHFbuSDszzaWppSsH9mtO5lBc/EAXYAp0v8WeNSboiRE+ EFFGz5PHRwY0W9SHqM1ZXMPsqOCslEI//bk9/LyE= From: trondmy@kernel.org To: "J. Bruce Fields" , Chuck Lever Cc: linux-nfs@vger.kernel.org Subject: [PATCH 1/2] nfsd: Avoid /* Fallthrough */ Date: Mon, 30 Nov 2020 23:14:26 -0500 Message-Id: <20201201041427.756749-1-trondmy@kernel.org> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Trond Myklebust The '/* Fallthrough */' comment is already deprecated. Avoid it. Signed-off-by: Trond Myklebust --- fs/nfsd/nfsfh.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c index 46c86f7bc429..e80a7525561d 100644 --- a/fs/nfsd/nfsfh.c +++ b/fs/nfsd/nfsfh.c @@ -302,9 +302,9 @@ static __be32 nfsd_set_fh_dentry(struct svc_rqst *rqstp, struct svc_fh *fhp) switch (rqstp->rq_vers) { case 3: - if (!(dentry->d_sb->s_export_op->flags & EXPORT_OP_NOWCC)) - break; - /* Fallthrough */ + if (dentry->d_sb->s_export_op->flags & EXPORT_OP_NOWCC) + fhp->fh_no_wcc = true; + break; case 2: fhp->fh_no_wcc = true; } -- 2.28.0