From: schumaker.anna@gmail.com
To: linux-nfs@vger.kernel.org
Cc: Anna.Schumaker@Netapp.com
Subject: [PATCH 2/3] NFS: Allocate a scratch page for READ_PLUS
Date: Thu, 3 Dec 2020 15:18:40 -0500 [thread overview]
Message-ID: <20201203201841.103294-3-Anna.Schumaker@Netapp.com> (raw)
In-Reply-To: <20201203201841.103294-1-Anna.Schumaker@Netapp.com>
From: Anna Schumaker <Anna.Schumaker@Netapp.com>
We might need this to better handle shifting around data in the reply
buffer.
Suggested-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
---
fs/nfs/nfs42xdr.c | 2 ++
fs/nfs/read.c | 13 +++++++++++--
include/linux/nfs_xdr.h | 1 +
3 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/fs/nfs/nfs42xdr.c b/fs/nfs/nfs42xdr.c
index 8432bd6b95f0..ef095a5f86f7 100644
--- a/fs/nfs/nfs42xdr.c
+++ b/fs/nfs/nfs42xdr.c
@@ -1297,6 +1297,8 @@ static int nfs4_xdr_dec_read_plus(struct rpc_rqst *rqstp,
struct compound_hdr hdr;
int status;
+ xdr_set_scratch_buffer(xdr, page_address(res->scratch), PAGE_SIZE);
+
status = decode_compound_hdr(xdr, &hdr);
if (status)
goto out;
diff --git a/fs/nfs/read.c b/fs/nfs/read.c
index eb854f1f86e2..012deb5a136f 100644
--- a/fs/nfs/read.c
+++ b/fs/nfs/read.c
@@ -37,15 +37,24 @@ static struct kmem_cache *nfs_rdata_cachep;
static struct nfs_pgio_header *nfs_readhdr_alloc(void)
{
- struct nfs_pgio_header *p = kmem_cache_zalloc(nfs_rdata_cachep, GFP_KERNEL);
+ struct nfs_pgio_header *p;
+ struct page *page;
- if (p)
+ page = alloc_page(GFP_KERNEL);
+ if (!page)
+ return ERR_PTR(-ENOMEM);
+
+ p = kmem_cache_zalloc(nfs_rdata_cachep, GFP_KERNEL);
+ if (p) {
p->rw_mode = FMODE_READ;
+ p->res.scratch = page;
+ }
return p;
}
static void nfs_readhdr_free(struct nfs_pgio_header *rhdr)
{
+ __free_page(rhdr->res.scratch);
kmem_cache_free(nfs_rdata_cachep, rhdr);
}
diff --git a/include/linux/nfs_xdr.h b/include/linux/nfs_xdr.h
index d63cb862d58e..e0a1c97f11a9 100644
--- a/include/linux/nfs_xdr.h
+++ b/include/linux/nfs_xdr.h
@@ -659,6 +659,7 @@ struct nfs_pgio_res {
struct nfs_fattr * fattr;
__u64 count;
__u32 op_status;
+ struct page * scratch;
union {
struct {
unsigned int replen; /* used by read */
--
2.29.2
next prev parent reply other threads:[~2020-12-03 20:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 20:18 [PATCH 0/3] NFS: Disable READ_PLUS by default schumaker.anna
2020-12-03 20:18 ` [PATCH 1/3] " schumaker.anna
2020-12-03 20:18 ` schumaker.anna [this message]
2020-12-03 20:27 ` [PATCH 2/3] NFS: Allocate a scratch page for READ_PLUS Chuck Lever
2020-12-03 20:31 ` Anna Schumaker
2020-12-03 20:39 ` Trond Myklebust
2020-12-04 16:14 ` Chuck Lever
2020-12-03 20:18 ` [PATCH 3/3] SUNRPC: Keep buf->len in sync with xdr->nwords when expanding holes schumaker.anna
2020-12-04 15:47 ` [PATCH 0/3] NFS: Disable READ_PLUS by default Mkrtchyan, Tigran
2020-12-04 20:00 ` Olga Kornievskaia
2020-12-04 22:50 ` Mkrtchyan, Tigran
2020-12-07 15:26 ` Mkrtchyan, Tigran
2020-12-07 15:54 ` Mkrtchyan, Tigran
2020-12-08 12:39 ` Mkrtchyan, Tigran
2020-12-08 13:38 ` Anna Schumaker
2020-12-09 18:23 ` Mkrtchyan, Tigran
2020-12-09 16:59 ` Trond Myklebust
2020-12-09 17:07 ` Olga Kornievskaia
2020-12-09 17:12 ` Trond Myklebust
2020-12-09 17:22 ` Olga Kornievskaia
2020-12-09 17:28 ` Anna Schumaker
2020-12-09 17:39 ` Olga Kornievskaia
2020-12-09 17:32 ` Trond Myklebust
2020-12-09 17:40 ` Olga Kornievskaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203201841.103294-3-Anna.Schumaker@Netapp.com \
--to=schumaker.anna@gmail.com \
--cc=Anna.Schumaker@Netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).