Re: [pynfs 03/10] Close the file for SEQ10b

Thomas Haynes
2020-12-21T05:07:36Z

> On Dec 18, 2020, at 8:43 AM, J. Bruce Fields <bfields@fieldses.org> wrote:
>
> On Wed, Dec 16, 2020 at 04:35:09PM -0800, Tom Haynes wrote:
>>
>> close_file(sess1, fh, stateid=stateid)
>>
>> + # Cleanup
>> + res = sess1.compound([op.putfh(fh), op.close(0, stateid)])
>> + check(res)
>> +
>
> This is giving me:
>
> SEQ10b st_sequence.testReplayCache007 : FAILURE
> OP_CLOSE should return NFS4_OK, instead got
> NFS4ERR_BAD_STATEID
>
> probably because the file was already closed just above. I'm not sure
> whta was intended here. Reverting for now.
>
> —b

Ahh, that close is not there in the branch we have internally. And since git took the change, I thought it was still good.

Backing out is cool.