From: Amir Goldstein <amir73il@gmail.com>
To: "J . Bruce Fields" <bfields@fieldses.org>,
Jeff Layton <jlayton@poochiereds.net>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 0/2] Improvements to nfsd stats
Date: Mon, 28 Dec 2020 19:03:42 +0200 [thread overview]
Message-ID: <20201228170344.22867-1-amir73il@gmail.com> (raw)
Hi Bruce,
The original motivation for this work was to add per-export stats.
While doing so, I noticed that most nfsd stats variables are not
protected against concurrent update, so fixed that first.
There are still a couple stats variables (longest_chain*) that are
not counters so less trivial to fix. I did not touch them.
There is also an eyebrow raising number of variabled in nfsd_stats
struct that are never updated. I did not touch those either.
If you want me to send a cleanup patch to remove them and print
hardcoded zeroes in the nfsd stats file I can do that.
Thanks,
Amir.
Amir Goldstein (2):
nfsd: protect concurrent access to nfsd stats counters
nfsd: report per-export stats
fs/nfsd/export.c | 68 +++++++++++++++++++++++++++++++-----
fs/nfsd/export.h | 17 +++++++++
fs/nfsd/netns.h | 20 +++++++----
fs/nfsd/nfs4proc.c | 2 +-
fs/nfsd/nfscache.c | 52 +++++++++++++++++++--------
fs/nfsd/nfsctl.c | 8 ++++-
fs/nfsd/nfsfh.c | 9 +++--
fs/nfsd/stats.c | 87 ++++++++++++++++++++++++++++++++++++----------
fs/nfsd/stats.h | 42 +++++++++++++++-------
fs/nfsd/vfs.c | 6 ++--
10 files changed, 243 insertions(+), 68 deletions(-)
--
2.17.1
next reply other threads:[~2020-12-28 17:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 17:03 Amir Goldstein [this message]
2020-12-28 17:03 ` [PATCH 1/2] nfsd: protect concurrent access to nfsd stats counters Amir Goldstein
2020-12-28 19:53 ` Chuck Lever
2021-01-04 21:55 ` J . Bruce Fields
2021-01-04 22:22 ` Amir Goldstein
2021-01-04 22:34 ` J . Bruce Fields
2021-01-05 2:12 ` Chuck Lever
2021-01-05 6:29 ` Amir Goldstein
2020-12-28 17:03 ` [PATCH 2/2] nfsd: report per-export stats Amir Goldstein
2021-01-04 22:49 ` J . Bruce Fields
2021-01-05 6:42 ` Amir Goldstein
2021-01-05 15:34 ` J . Bruce Fields
2021-01-05 15:45 ` Amir Goldstein
2021-01-05 18:32 ` J . Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201228170344.22867-1-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox