Re: [PATCH v2 0/3] Improvements to nfsd stats

Chuck Lever
2021-01-21T23:40:12Z

Hello Amir!

> On Jan 6, 2021, at 2:52 AM, Amir Goldstein <amir73il@gmail.com> wrote:
>
> Hi Bruce,
>
> Per your request, I added a cleanup patch for unused counter.
>
> Replaced the hacky counters array "union" with proper array
> and added helpers to update the counters to avoid human mistakes
> related to counter indices.

Thanks for your patches. v2 of your series has been committed
to the for-next branch at

git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git

in preparation for the v5.12 merge window.

> Thanks,
> Amir.
>
> Changes since v1:
> - Cleanup unused stats counters (Bruce)
> - Replace counters array hack with proper array (Chuck)
> - Helpers to update both global and per-export stats
>
> Amir Goldstein (3):
> nfsd: remove unused stats counters
> nfsd: protect concurrent access to nfsd stats counters
> nfsd: report per-export stats
>
> fs/nfsd/export.c | 68 +++++++++++++++++++++++----
> fs/nfsd/export.h | 15 ++++++
> fs/nfsd/netns.h | 23 +++++----
> fs/nfsd/nfs4proc.c | 2 +-
> fs/nfsd/nfscache.c | 52 +++++++++++++++------
> fs/nfsd/nfsctl.c | 8 +++-
> fs/nfsd/nfsd.h | 2 +-
> fs/nfsd/nfsfh.c | 4 +-
> fs/nfsd/stats.c | 114 +++++++++++++++++++++++++++++++--------------
> fs/nfsd/stats.h | 96 +++++++++++++++++++++++++++++---------
> fs/nfsd/vfs.c | 4 +-
> 11 files changed, 292 insertions(+), 96 deletions(-)
>
> --
> 2.17.1
>

--
Chuck Lever