From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC312C433E0 for ; Fri, 22 Jan 2021 22:17:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6CE023B18 for ; Fri, 22 Jan 2021 22:17:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728410AbhAVWQg (ORCPT ); Fri, 22 Jan 2021 17:16:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728812AbhAVT7g (ORCPT ); Fri, 22 Jan 2021 14:59:36 -0500 Received: from fieldses.org (fieldses.org [IPv6:2600:3c00:e000:2f7::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FD49C0613D6 for ; Fri, 22 Jan 2021 11:58:56 -0800 (PST) Received: by fieldses.org (Postfix, from userid 2815) id AF1336EA0; Fri, 22 Jan 2021 14:58:54 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.11.0 fieldses.org AF1336EA0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fieldses.org; s=default; t=1611345534; bh=gsE9EZNiDx/qqx9lGltp9Msrs6A6fJF7780HTnP5YfY=; h=Date:To:Cc:Subject:References:In-Reply-To:From:From; b=JqMKYhVs8Il/H2CYHAbhQ2HuFpudUGaqwCVQWfurKCJ37dQ0QGb6F2nUKq+fFcKU+ JvhMLcxv8syor/3bQObSEAoVUNTrhOGXO6YX8A0MvX1X1WWb1eoT6ZnQwVpR/dLitr 6xUCJErkg7KL77Y/9x2uc2ImnrHkyN/Qy8I172Ok= Date: Fri, 22 Jan 2021 14:58:54 -0500 To: Chuck Lever Cc: linux-nfs@vger.kernel.org Subject: Re: [PATCH v1 00/42] Update NFSD XDR functions Message-ID: <20210122195854.GD18583@fieldses.org> References: <160986050640.5532.16498408936966394862.stgit@klimt.1015granger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <160986050640.5532.16498408936966394862.stgit@klimt.1015granger.net> User-Agent: Mutt/1.5.21 (2010-09-15) From: bfields@fieldses.org (J. Bruce Fields) Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org ACK to the patches, looks good to me.--b. On Tue, Jan 05, 2021 at 10:29:40AM -0500, Chuck Lever wrote: > The long-term purpose is to convert the NFSD XDR encoder and decoder > functions to use the struct xdr_stream API. This is a refactor and > clean-up with few or no changes in behavior expected, but there are > some long-term benefits: > > - More robust input sanitization in the NFSD decoders. > - Help make it possible to use common kernel library functions with > XDR stream APIs (for example, GSS-API). > - Align the structure of the source code with the RFCs so it is > easier to learn, verify, and maintain our XDR implementation. > - Removal of more than a hundred hidden dprintk() call sites. > - Removal of as much explicit manipulation of pages as possible to > help make the eventual transition to xdr->bvecs smoother. > > The current series focuses on NFSv2 and NFSv3 decoder changes. Please > review and comment! > > The full set of patches lives in a topic branch in my git repo: > > git://git.linux-nfs.org/projects/cel/cel-2.6.git nfsd-xdr_stream > > > --- > > Chuck Lever (42): > SUNRPC: Make trace_svc_process() display the RPC procedure symbolically > SUNRPC: Display RPC procedure names instead of proc numbers > SUNRPC: Move definition of XDR_UNIT > NFSD: Update GETATTR3args decoder to use struct xdr_stream > NFSD: Update ACCESS3arg decoder to use struct xdr_stream > NFSD: Update READ3arg decoder to use struct xdr_stream > NFSD: Update WRITE3arg decoder to use struct xdr_stream > NFSD: Update READLINK3arg decoder to use struct xdr_stream > NFSD: Fix returned READDIR offset cookie > NFSD: Add helper to set up the pages where the dirlist is encoded > NFSD: Update READDIR3args decoders to use struct xdr_stream > NFSD: Update COMMIT3arg decoder to use struct xdr_stream > NFSD: Update the NFSv3 DIROPargs decoder to use struct xdr_stream > NFSD: Update the RENAME3args decoder to use struct xdr_stream > NFSD: Update the LINK3args decoder to use struct xdr_stream > NFSD: Update the SETATTR3args decoder to use struct xdr_stream > NFSD: Update the CREATE3args decoder to use struct xdr_stream > NFSD: Update the MKDIR3args decoder to use struct xdr_stream > NFSD: Update the SYMLINK3args decoder to use struct xdr_stream > NFSD: Update the MKNOD3args decoder to use struct xdr_stream > NFSD: Update the NFSv2 GETATTR argument decoder to use struct xdr_stream > NFSD: Update the NFSv2 READ argument decoder to use struct xdr_stream > NFSD: Update the NFSv2 WRITE argument decoder to use struct xdr_stream > NFSD: Update the NFSv2 READLINK argument decoder to use struct xdr_stream > NFSD: Add helper to set up the pages where the dirlist is encoded > NFSD: Update the NFSv2 READDIR argument decoder to use struct xdr_stream > NFSD: Update NFSv2 diropargs decoding to use struct xdr_stream > NFSD: Update the NFSv2 RENAME argument decoder to use struct xdr_stream > NFSD: Update the NFSv2 LINK argument decoder to use struct xdr_stream > NFSD: Update the NFSv2 SETATTR argument decoder to use struct xdr_stream > NFSD: Update the NFSv2 CREATE argument decoder to use struct xdr_stream > NFSD: Update the NFSv2 SYMLINK argument decoder to use struct xdr_stream > NFSD: Remove argument length checking in nfsd_dispatch() > NFSD: Update the NFSv2 GETACL argument decoder to use struct xdr_stream > NFSD: Add an xdr_stream-based decoder for NFSv2/3 ACLs > NFSD: Update the NFSv2 SETACL argument decoder to use struct xdr_stream > NFSD: Update the NFSv2 ACL GETATTR argument decoder to use struct xdr_stream > NFSD: Update the NFSv2 ACL ACCESS argument decoder to use struct xdr_stream > NFSD: Clean up after updating NFSv2 ACL decoders > NFSD: Update the NFSv3 GETACL argument decoder to use struct xdr_stream > NFSD: Update the NFSv2 SETACL argument decoder to use struct xdr_stream > NFSD: Clean up after updating NFSv3 ACL decoders > > > fs/nfs_common/nfsacl.c | 52 +++ > fs/nfsd/nfs2acl.c | 62 ++-- > fs/nfsd/nfs3acl.c | 42 ++- > fs/nfsd/nfs3proc.c | 71 +++-- > fs/nfsd/nfs3xdr.c | 538 ++++++++++++++++++-------------- > fs/nfsd/nfsproc.c | 74 +++-- > fs/nfsd/nfssvc.c | 34 -- > fs/nfsd/nfsxdr.c | 350 ++++++++++----------- > fs/nfsd/xdr.h | 12 +- > fs/nfsd/xdr3.h | 20 +- > include/linux/nfsacl.h | 3 + > include/linux/sunrpc/msg_prot.h | 3 - > include/linux/sunrpc/xdr.h | 13 +- > include/trace/events/sunrpc.h | 15 +- > include/uapi/linux/nfs3.h | 6 + > 15 files changed, 680 insertions(+), 615 deletions(-) > > -- > Chuck Lever