Re: [PATCH 2/3] nfsd: move change attribute generation to filesystem

Christoph Hellwig
2021-01-20T09:01:44Z

On Tue, Jan 19, 2021 at 02:24:56PM -0500, J. Bruce Fields wrote:
> From: "J. Bruce Fields" <bfields@redhat.com>
>
> After this, only filesystems lacking change attribute support will leave
> the fetch_iversion export op NULL.
>
> This seems cleaner to me, and will allow some minor optimizations in the
> nfsd code.

Another indirect call just to fetch the change attribute (which happens
a lot IIRC) does not seem very optimal to me. And the fact that we need
three duplicate implementations also is not very nice.