From: trondmy@kernel.org
To: Anna Schumaker <anna.schumaker@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 1/3] NFS: 'flags' field should be unsigned in struct nfs_server
Date: Fri, 12 Feb 2021 16:49:47 -0500 [thread overview]
Message-ID: <20210212214949.4408-2-trondmy@kernel.org> (raw)
In-Reply-To: <20210212214949.4408-1-trondmy@kernel.org>
From: Trond Myklebust <trond.myklebust@hammerspace.com>
The mount flags are all unsigned integers, so we should not be storing
them in a signed field.
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
---
include/linux/nfs_fs_sb.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/nfs_fs_sb.h b/include/linux/nfs_fs_sb.h
index 38e60ec742df..962e8313f007 100644
--- a/include/linux/nfs_fs_sb.h
+++ b/include/linux/nfs_fs_sb.h
@@ -142,7 +142,7 @@ struct nfs_server {
struct nlm_host *nlm_host; /* NLM client handle */
struct nfs_iostats __percpu *io_stats; /* I/O statistics */
atomic_long_t writeback; /* number of writeback pages */
- int flags; /* various flags */
+ unsigned int flags; /* various flags */
/* The following are for internal use only. Also see uapi/linux/nfs_mount.h */
#define NFS_MOUNT_LOOKUP_CACHE_NONEG 0x10000
--
2.29.2
next prev parent reply other threads:[~2021-02-12 21:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 21:49 [PATCH 0/3] Add a mount option to support eager writes trondmy
2021-02-12 21:49 ` trondmy [this message]
2021-02-12 21:49 ` [PATCH 2/3] NFS: Add support for " trondmy
2021-02-12 21:49 ` [PATCH 3/3] NFS: Add mount options supporting " trondmy
2021-02-13 14:19 ` [PATCH 0/3] Add a mount option to support " Steve Dickson
2021-02-13 14:20 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210212214949.4408-2-trondmy@kernel.org \
--to=trondmy@kernel.org \
--cc=anna.schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox