* pynfs breakage
@ 2021-02-15 20:15 Jeff Layton
2021-02-15 20:17 ` Bruce Fields
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Layton @ 2021-02-15 20:15 UTC (permalink / raw)
To: Bruce Fields; +Cc: open list:NFS, SUNRPC, AND...
Hi Bruce!
The latest HEAD in pynfs doesn't run for me:
$ ./nfs4.1/testserver.py --help
Traceback (most recent call last):
File "/home/jlayton/git/pynfs/nfs4.1/./testserver.py", line 38, in <module>
import server41tests.environment as environment
File "/home/jlayton/git/pynfs/nfs4.1/server41tests/environment.py", line 593
def write_file(sess, file, data, offset=0 stateid=stateid4(0, b''),
^
SyntaxError: invalid syntax
If I revert this commit, then it works:
commit 49ae5ba83dd98936b3f5c24431a166866b70f34a (HEAD -> master, origin/master, origin/HEAD)
Author: J. Bruce Fields <bfields@redhat.com>
Date: Thu Feb 11 16:22:58 2021 -0500
nfs41: read_file and write_file helpers
A couple simple helpers copied from 4.0.
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Cheers,
--
Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: pynfs breakage
2021-02-15 20:15 pynfs breakage Jeff Layton
@ 2021-02-15 20:17 ` Bruce Fields
2021-02-15 21:22 ` Bruce Fields
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Fields @ 2021-02-15 20:17 UTC (permalink / raw)
To: Jeff Layton; +Cc: open list:NFS, SUNRPC, AND...
On Mon, Feb 15, 2021 at 03:15:08PM -0500, Jeff Layton wrote:
> Hi Bruce!
>
> The latest HEAD in pynfs doesn't run for me:
>
> $ ./nfs4.1/testserver.py --help
> Traceback (most recent call last):
> File "/home/jlayton/git/pynfs/nfs4.1/./testserver.py", line 38, in <module>
> import server41tests.environment as environment
> File "/home/jlayton/git/pynfs/nfs4.1/server41tests/environment.py", line 593
> def write_file(sess, file, data, offset=0 stateid=stateid4(0, b''),
> ^
> SyntaxError: invalid syntax
>
> If I revert this commit, then it works:
Yeah, sorry about that, I pushed out quickly thinking I'd tested it, but
in fact it has a bunch of mistakes. Fixing....
--b.
>
> commit 49ae5ba83dd98936b3f5c24431a166866b70f34a (HEAD -> master, origin/master, origin/HEAD)
> Author: J. Bruce Fields <bfields@redhat.com>
> Date: Thu Feb 11 16:22:58 2021 -0500
>
> nfs41: read_file and write_file helpers
>
> A couple simple helpers copied from 4.0.
>
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
>
>
> Cheers,
> --
> Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: pynfs breakage
2021-02-15 20:17 ` Bruce Fields
@ 2021-02-15 21:22 ` Bruce Fields
2021-02-15 21:23 ` Jeff Layton
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Fields @ 2021-02-15 21:22 UTC (permalink / raw)
To: Jeff Layton; +Cc: open list:NFS, SUNRPC, AND...
On Mon, Feb 15, 2021 at 03:17:28PM -0500, Bruce Fields wrote:
> On Mon, Feb 15, 2021 at 03:15:08PM -0500, Jeff Layton wrote:
> > Hi Bruce!
> >
> > The latest HEAD in pynfs doesn't run for me:
> >
> > $ ./nfs4.1/testserver.py --help
> > Traceback (most recent call last):
> > File "/home/jlayton/git/pynfs/nfs4.1/./testserver.py", line 38, in <module>
> > import server41tests.environment as environment
> > File "/home/jlayton/git/pynfs/nfs4.1/server41tests/environment.py", line 593
> > def write_file(sess, file, data, offset=0 stateid=stateid4(0, b''),
> > ^
> > SyntaxError: invalid syntax
> >
> > If I revert this commit, then it works:
>
> Yeah, sorry about that, I pushed out quickly thinking I'd tested it, but
> in fact it has a bunch of mistakes. Fixing....
Should be fixed, apologies again.--b.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: pynfs breakage
2021-02-15 21:22 ` Bruce Fields
@ 2021-02-15 21:23 ` Jeff Layton
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Layton @ 2021-02-15 21:23 UTC (permalink / raw)
To: Bruce Fields; +Cc: open list:NFS, SUNRPC, AND...
On Mon, 2021-02-15 at 16:22 -0500, Bruce Fields wrote:
> On Mon, Feb 15, 2021 at 03:17:28PM -0500, Bruce Fields wrote:
> > On Mon, Feb 15, 2021 at 03:15:08PM -0500, Jeff Layton wrote:
> > > Hi Bruce!
> > >
> > > The latest HEAD in pynfs doesn't run for me:
> > >
> > > $ ./nfs4.1/testserver.py --help
> > > Traceback (most recent call last):
> > > File "/home/jlayton/git/pynfs/nfs4.1/./testserver.py", line 38, in <module>
> > > import server41tests.environment as environment
> > > File "/home/jlayton/git/pynfs/nfs4.1/server41tests/environment.py", line 593
> > > def write_file(sess, file, data, offset=0 stateid=stateid4(0, b''),
> > > ^
> > > SyntaxError: invalid syntax
> > >
> > > If I revert this commit, then it works:
> >
> > Yeah, sorry about that, I pushed out quickly thinking I'd tested it, but
> > in fact it has a bunch of mistakes. Fixing....
>
> Should be fixed, apologies again.--b.
No worries. Thanks for fixing it so fast!
--
Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-15 21:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-15 20:15 pynfs breakage Jeff Layton
2021-02-15 20:17 ` Bruce Fields
2021-02-15 21:22 ` Bruce Fields
2021-02-15 21:23 ` Jeff Layton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox