From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A384BC433DB for ; Wed, 24 Feb 2021 21:00:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4963164E60 for ; Wed, 24 Feb 2021 21:00:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232290AbhBXVAS (ORCPT ); Wed, 24 Feb 2021 16:00:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232058AbhBXVAR (ORCPT ); Wed, 24 Feb 2021 16:00:17 -0500 Received: from fieldses.org (fieldses.org [IPv6:2600:3c00:e000:2f7::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F21D9C061574 for ; Wed, 24 Feb 2021 12:59:37 -0800 (PST) Received: by fieldses.org (Postfix, from userid 2815) id 6C4BA21DD; Wed, 24 Feb 2021 15:59:37 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.11.0 fieldses.org 6C4BA21DD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fieldses.org; s=default; t=1614200377; bh=KmcGi/MpXXC2Of0/17qM/ZYTO/w0JvJzW19zUXFGk0I=; h=Date:To:Cc:Subject:References:In-Reply-To:From:From; b=HfWt9tpOIxdlxHFV8C1VCNH8D21m3/FkTv6YZxd4UymKEpoXuNlVeeYE0qE+WxdVF wchT8l69i/XCHoGctPJ2kJsaE9jo2CpvIB+OhzbHVnTgD+i2N5GYN+WCSUIKF7YxQs ket8/FhQ8O+ZDA44KGdJ0XCcBBpQha7J1qU6sa9g= Date: Wed, 24 Feb 2021 15:59:37 -0500 To: trondmy@kernel.org Cc: "J. Bruce Fields" , Chuck Lever , linux-nfs@vger.kernel.org Subject: Re: [PATCH] nfsd: Don't keep looking up unhashed files in the nfsd file cache Message-ID: <20210224205937.GH11591@fieldses.org> References: <20210219020207.688592-1-trondmy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210219020207.688592-1-trondmy@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) From: bfields@fieldses.org (J. Bruce Fields) Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Thu, Feb 18, 2021 at 09:02:07PM -0500, trondmy@kernel.org wrote: > From: Trond Myklebust > > If a file is unhashed, then we're going to reject it anyway and retry, > so make sure we skip it when we're doing the RCU lockless lookup. > This avoids a number of unnecessary nfserr_jukebox returns from > nfsd_file_acquire() Looks good to me.--b. > > Fixes: 65294c1f2c5e ("nfsd: add a new struct file caching facility to nfsd") > Signed-off-by: Trond Myklebust > --- > fs/nfsd/filecache.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c > index 53fcbf79bdca..7629248fdd53 100644 > --- a/fs/nfsd/filecache.c > +++ b/fs/nfsd/filecache.c > @@ -898,6 +898,8 @@ nfsd_file_find_locked(struct inode *inode, unsigned int may_flags, > continue; > if (!nfsd_match_cred(nf->nf_cred, current_cred())) > continue; > + if (!test_bit(NFSD_FILE_HASHED, &nf->nf_flags)) > + continue; > if (nfsd_file_get(nf) != NULL) > return nf; > } > -- > 2.29.2