Re: [PATCH 1/2] NFSD: delay unmount source's export after inter-server copy completed.

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2860 bytes --]

Hi Dai,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on nfs/linux-next]
[also build test WARNING on v5.12-rc5 next-20210401]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Dai-Ngo/enhance-NFSv4-2-SSC-to-delay-unmount-source-s-export/20210402-071534
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/84c442c7d2275ebcf694b23503725a5a5d7895e5
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Dai-Ngo/enhance-NFSv4-2-SSC-to-delay-unmount-source-s-export/20210402-071534
        git checkout 84c442c7d2275ebcf694b23503725a5a5d7895e5
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> fs/nfsd/nfs4proc.c:81:6: warning: no previous prototype for 'nfsd4_ssc_expire_umount' [-Wmissing-prototypes]
      81 | void nfsd4_ssc_expire_umount(struct work_struct *work)
         |      ^~~~~~~~~~~~~~~~~~~~~~~


vim +/nfsd4_ssc_expire_umount +81 fs/nfsd/nfs4proc.c

    80	
  > 81	void nfsd4_ssc_expire_umount(struct work_struct *work)
    82	{
    83		struct nfsd4_ssc_umount_item *ni = 0;
    84		struct nfsd4_ssc_umount_item *tmp;
    85	
    86		down_write(&nfsd4_ssc_umount.nsu_sem);
    87		spin_lock(&nfsd4_ssc_umount.nsu_lock);
    88		list_for_each_entry_safe(ni, tmp, &nfsd4_ssc_umount.nsu_list, nsui_list) {
    89			if (time_after(jiffies, ni->nsui_expire)) {
    90				list_del(&ni->nsui_list);
    91				cancel_delayed_work(&nfsd4_ssc_umount.nsu_umount_work);
    92				spin_unlock(&nfsd4_ssc_umount.nsu_lock);
    93				up_write(&nfsd4_ssc_umount.nsu_sem);
    94	
    95				mntput(ni->nsui_vfsmount);
    96				kfree(ni);
    97	
    98				down_write(&nfsd4_ssc_umount.nsu_sem);
    99				spin_lock(&nfsd4_ssc_umount.nsu_lock);
   100				continue;
   101			}
   102			break;
   103		}
   104		nfsd4_scc_update_umnt_timo();
   105		spin_unlock(&nfsd4_ssc_umount.nsu_lock);
   106		up_write(&nfsd4_ssc_umount.nsu_sem);
   107	}
   108	EXPORT_SYMBOL_GPL(nfsd4_ssc_expire_umount);
   109	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 70235 bytes --]