public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: "Kornievskaia, Olga" <Olga.Kornievskaia@netapp.com>
Cc: Trond Myklebust <trondmy@hammerspace.com>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: generic/430 COPY/delegation caching regression
Date: Wed, 14 Apr 2021 09:49:35 -0400	[thread overview]
Message-ID: <20210414134935.GA16800@fieldses.org> (raw)
In-Reply-To: <0A9B34DB-56CF-4F22-8A8E-F6CA3176144D@netapp.com>

On Wed, Apr 14, 2021 at 03:30:19AM +0000, Kornievskaia, Olga wrote:
> On 4/13/21, 7:20 PM, "J. Bruce Fields" <bfields@fieldses.org> wrote:
>     generic/430 started failing in 4.12-rc3, as of 7c1d1dcc24b3 "nfsd: grant
>     read delegations to clients holding writes".
> 
>     Looks like that reintroduced the problem fixed by 16abd2a0c124 "NFSv4.2:
>     fix client's attribute cache management for copy_file_range": the client
>     needs to invalidate its cache of the destination of a copy even when it
>     holds a delegation.
> 
> [olga] I'm confused what client version are you testing and against what server? I haven't seen generic/430 failing while testing upstream versions against upstream server verions. What should I try (as in what client version against what server version) to reproduce the failure?

You can reproduce it with client and server both on rc3.

(In more detail: you need a client with 7c1d1dcc24b3, but a server that
doesn't yet have 6ee65a773096 "Revert "nfsd4: a client's own opens
needn't prevent delegation"".

I have a patch that will restore the server's ability to grant
delegations to clients with write opens, but this regression was one of
the problems I ran across in testing....)

--b.

      reply	other threads:[~2021-04-14 13:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13 23:19 generic/430 COPY/delegation caching regression J. Bruce Fields
2021-04-14  3:09 ` Trond Myklebust
2021-04-14 14:04   ` bfields
2021-04-14  3:30 ` Kornievskaia, Olga
2021-04-14 13:49   ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210414134935.GA16800@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=Olga.Kornievskaia@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trondmy@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox