Re: [PATCH 0/3] Enable the setting of a kernel module parameter from nfs.conf

Chuck Lever III
2021-04-14T23:27:02Z

Hi Steve-

> On Apr 14, 2021, at 2:10 PM, Steve Dickson <SteveD@redhat.com> wrote:
>
> ﻿This is a tweak of the patch set Alice Mitchell posted last July [1].

That approach was dropped last July because it is not container-aware.
It should be simple for someone to write a udev script that uses the
existing sysfs API that can update nfs4_client_id in a namespace. I
would prefer the sysfs/udev approach for setting nfs4_client_id,
since it is container-aware and makes this setting completely
automatic (zero touch).

> It enables the setting of the nfs4_unique_id kernel module
> parameter from /etc/nfs.conf.

> Things I tweaked:
>
> * Introduce a new [kernel] section in nfs.conf which only
> contains the nfs4_unique_id setting... For now...
>
> * nfs4_unique_id can be set to two different values
>
> - nfs4_unique_id = ${machine-id} will use /etc/machine-id
> as the unique id.
> - nfs4_unique_id = ${hostname} will use the system's hostname
> as the unique id.
>
> * The new nfs-config systemd service need to be enabled for the
> /etc/modprobe.d/nfs.conf file to be created with
> the "options nfs nfs4_unique_id=" set.
>
> I see this patch set is not a way to set the nfs4_unique_id
> module parameter... I see it as a beginning of a way to set
> all module parameters from /etc/nfs.conf, which I think
> is a good thing...
>
> [1] https://www.spinics.net/lists/linux-nfs/msg78658.html
>
> Alice Mitchell (3):
> nfs-utils: Enable the retrieval of raw config settings without
> expansion
> nfs-utils: Add support for further ${variable} expansions in nfs.conf
> nfs-utils: Update nfs4_unique_id module parameter from the nfs.conf
> value
>
> configure.ac | 1 +
> nfs.conf | 4 +-
> support/include/conffile.h | 1 +
> support/nfs/conffile.c | 283 ++++++++++++++++++++++++++++++++--
> systemd/Makefile.am | 3 +
> systemd/nfs-client.target | 3 +
> systemd/nfs-conf-export.sh | 28 ++++
> systemd/nfs-config.service.in | 18 +++
> systemd/nfs.conf.man | 19 ++-
> tools/nfsconf/nfsconf.man | 10 +-
> tools/nfsconf/nfsconfcli.c | 22 ++-
> 11 files changed, 372 insertions(+), 20 deletions(-)
> create mode 100755 systemd/nfs-conf-export.sh
> create mode 100644 systemd/nfs-config.service.in
>
> --
> 2.30.2
>