Re: [PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote_mem()

Al Viro
2021-05-03T20:54:05Z

On Mon, May 03, 2021 at 11:49:05PM +0300, Andy Shevchenko wrote:
> string_escape_mem_ascii() followed by seq_escape_mem_ascii() is completely
> non-flexible and shouldn't be exist from day 1.
>
> Replace it with properly called string_escape_mem().

NAKed-by: Al Viro <viro@zeniv.linux.org.uk>

Reason: use of seq_get_buf(). Which should have been static inline in
fs/seq_file.c, to start with.

Again, any new uses of seq_get_buf()/seq_commit() are grounds for automatic
NAK. These interfaces *will* be withdrawn.