Re: [PATCH] nfsd: Prevent truncation of an unlinked inode from blocking access to its directory

Christoph Hellwig
2021-05-18T07:34:34Z

On Mon, May 17, 2021 at 02:56:59PM -0400, bfields@fieldses.org wrote:
> On Sat, May 15, 2021 at 08:02:39AM +0100, Christoph Hellwig wrote:
> > On Fri, May 14, 2021 at 03:46:57PM +0000, Trond Myklebust wrote:
> > > Why leave the commit_metadata() call under the lock? If you're
> > > concerned about latency, then it makes more sense to call fh_unlock()
> > > before flushing those metadata updates to disk.
> >
> > Also I'm not sure why the extra inode reference is needed. What speaks
> > against just moving the dput out of the locked section?
>
> I don't know. Do you know why do_unlinkat() is doing the same thing?

No. Al, any idea why unlink does the final dput under i_rwsem?