Re: [PATCH] nfsd: Prevent truncation of an unlinked inode from blocking access to its directory

bfields
2021-05-17T18:57:02Z

On Sat, May 15, 2021 at 08:02:39AM +0100, Christoph Hellwig wrote:
> On Fri, May 14, 2021 at 03:46:57PM +0000, Trond Myklebust wrote:
> > Why leave the commit_metadata() call under the lock? If you're
> > concerned about latency, then it makes more sense to call fh_unlock()
> > before flushing those metadata updates to disk.
>
> Also I'm not sure why the extra inode reference is needed. What speaks
> against just moving the dput out of the locked section?

I don't know. Do you know why do_unlinkat() is doing the same thing?

--b.