Re: [PATCH] pynfs: courtesy: send RECLAIM_COMPLETE before session2 opening the file

["J. Bruce Fields" <bfields@fieldses.org>]

On Tue, Jun 15, 2021 at 04:38:15PM +0100, Calum Mackay wrote:
> I wasn't quite sure on the semantics of those calls.
> 
> We want what appears to the server to be a new client c2, not a new
> session from an existing client c1. I wasn't sure whether
> new_client_session() would give us that?

Yes, it gets you both a new client and a new session for that client.
It does all the stuff you need to get a new client that you can actually
use for normal operations, so it should be the default unless you need
finer control.

(Also, *eventually*, I want to port all the 4.0 tests to the 4.1 code
and eliminate the separate 4.0/4.1 directories.  new_client_session will
then do either exchange_id+create_session+reclaim_complete or
setclientid+setclient_confirm depending on minor version.)

Anyway, so the names are totally unhelpful.  Maybe we should reanme
new_client to exchange_id and new_client_session to just new_client.

--b.