Re: [PATCH v1 2/4] SUNRPC: Server-side disconnect injection

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2370 bytes --]

Hi Chuck,

I love your patch! Yet something to improve:

[auto build test ERROR on nfs/linux-next]
[also build test ERROR on nfsd/nfsd-next linus/master v5.14-rc5 next-20210809]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Chuck-Lever/SunRPC-fault-injection/20210810-021150
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: i386-randconfig-r033-20210809 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/561bf84b4d936dc5ae88b55b133def1b7e50d263
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Chuck-Lever/SunRPC-fault-injection/20210810-021150
        git checkout 561bf84b4d936dc5ae88b55b133def1b7e50d263
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash net/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from net/sunrpc/svc.c:34:
>> net/sunrpc/fail.h:12:20: error: field 'attr' has incomplete type
      12 |  struct fault_attr attr;
         |                    ^~~~
   net/sunrpc/svc.c: In function 'svc_process':
>> net/sunrpc/svc.c:1509:6: error: implicit declaration of function 'should_fail'; did you mean 'should_failslab'? [-Werror=implicit-function-declaration]
    1509 |      should_fail(&fail_sunrpc.attr, 1))
         |      ^~~~~~~~~~~
         |      should_failslab
   cc1: some warnings being treated as errors


vim +/attr +12 net/sunrpc/fail.h

f6324480d4b27a2 Chuck Lever 2021-08-09  10  
f6324480d4b27a2 Chuck Lever 2021-08-09  11  struct fail_sunrpc_attr {
f6324480d4b27a2 Chuck Lever 2021-08-09 @12  	struct fault_attr	attr;
561bf84b4d936dc Chuck Lever 2021-08-09  13  
561bf84b4d936dc Chuck Lever 2021-08-09  14  	bool			ignore_server_disconnect;
f6324480d4b27a2 Chuck Lever 2021-08-09  15  };
f6324480d4b27a2 Chuck Lever 2021-08-09  16  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36621 bytes --]