From: "J. Bruce Fields" <bfields@fieldses.org>
To: Volodymyr Khomenko <volodymyr@vastdata.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: GSSAPI fix for pynfs nfs4.1 client code
Date: Fri, 1 Oct 2021 11:48:21 -0400 [thread overview]
Message-ID: <20211001154821.GE959@fieldses.org> (raw)
In-Reply-To: <CANkgwevJURTVNcs8u3KS_jiZwxQZgGHX=YmU+kvbweQ0PLBHiA@mail.gmail.com>
On Fri, Oct 01, 2021 at 05:38:45PM +0300, Volodymyr Khomenko wrote:
> > The seq_num field can start at any value below MAXSEQ
> Yes, that's the statement I haven't found before in RFC...
> Probably we also need to write a test starting the seq_num from a big
> value (more than SEQUENCE_WINDOW)
> to make sure that it is really implemented properly without
> 'is_inited' flag (so what's the initial value?).
>
> However I still propose to keep the default behaviour of pynfs to be
> the same as for linux NFS4 client.
> I think the caller can change it when needed (to 0 or whatever
> needed), but the default value should be good...
That's what I'd choose if I were writing a "real" client. Everybody
already tests with the Linux client, so its behavior is a safe bet.
But I'd usually prefer a test client do different things than the client
everyone already tests with.
Like I say, the seqid=0 already caught a bug in my server, so I'm a fan.
(And it's a bug that would also trigger if any of the first 128 rpcs
were out of order. But that would probably manifest as some user
reporting "once in a blue moon my krb5 mounts hang" and I think it would
take a while to get from that report to this bug as the root cause. So
I'm glad pynfs hit it....)
--b.
next prev parent reply other threads:[~2021-10-01 15:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 15:22 GSSAPI fix for pynfs nfs4.1 client code Volodymyr Khomenko
2021-09-30 21:11 ` J. Bruce Fields
2021-09-30 21:25 ` J. Bruce Fields
2021-10-01 6:27 ` Volodymyr Khomenko
2021-10-01 6:12 ` Volodymyr Khomenko
2021-10-01 6:49 ` Volodymyr Khomenko
2021-10-01 14:13 ` J. Bruce Fields
2021-10-01 14:38 ` Volodymyr Khomenko
2021-10-01 15:48 ` J. Bruce Fields [this message]
2021-10-02 6:12 ` Volodymyr Khomenko
2021-10-02 20:38 ` J. Bruce Fields
2021-10-01 20:55 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211001154821.GE959@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=volodymyr@vastdata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).