From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27D4EC433EF for ; Sun, 3 Oct 2021 00:08:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0195D61AA9 for ; Sun, 3 Oct 2021 00:08:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234248AbhJCAJw (ORCPT ); Sat, 2 Oct 2021 20:09:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:54688 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234236AbhJCAJw (ORCPT ); Sat, 2 Oct 2021 20:09:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6BE8961AA9 for ; Sun, 3 Oct 2021 00:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633219685; bh=8vRNBmIxbflQsC0Gsd4s5uXvnN4ZrvTwKRf1LikfBhw=; h=From:To:Subject:Date:From; b=RELbbSfRSV5AnEdxUjxBQgKIEnW/35j6JssK9sCS4NbcJBS/rauEgxNHdUPm+wWMC ArHklHF3lDEI69PZvRZLr48SSNja6o1Q+iUzW9IKwPtisL0L0VkXoeQg9iEsNcRPFI /Z9dgEfYr98UvnGc31tKYTFEPmqV+kM2FA1bj5UHvKLCzfhdFvYYIR1URAFqtZKMGd qjaOvZD1wYP4lwnqI3dKJBS1C3nB/RGN++1KcdO4tK8q0NJYCr2HkOR/FY6dwPoaWB tdWwEUuxX42NQqq9JRHLsB8Oa+Rmyv10chZzTm9Fi4UdsqSvaJZ4C9oOTLFCX8ahEl B8NlXe4qda7zQ== From: trondmy@kernel.org To: linux-nfs@vger.kernel.org Subject: [PATCH] NFS: Do not flush the readdir cache in nfs_dentry_iput() Date: Sat, 2 Oct 2021 20:08:04 -0400 Message-Id: <20211003000804.65661-1-trondmy@kernel.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Trond Myklebust The original premise in commit 83672d392f7b ("NFS: Fix directory caching problem - with test case and patch.") was that readdirplus was caching attribute information and replaying it later. This is no longer the case. Signed-off-by: Trond Myklebust --- fs/nfs/dir.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 3fafecdb2070..210c5945ac2b 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c @@ -1727,10 +1727,6 @@ static void nfs_drop_nlink(struct inode *inode) */ static void nfs_dentry_iput(struct dentry *dentry, struct inode *inode) { - if (S_ISDIR(inode->i_mode)) - /* drop any readdir cache as it could easily be old */ - nfs_set_cache_invalid(inode, NFS_INO_INVALID_DATA); - if (dentry->d_flags & DCACHE_NFSFS_RENAMED) { nfs_complete_unlink(dentry, inode); nfs_drop_nlink(inode); -- 2.31.1