linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Dai Ngo <dai.ngo@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/1] st_courtesy.py: add more tests for Courteous Server
Date: Tue, 5 Oct 2021 11:22:24 -0400	[thread overview]
Message-ID: <20211005152224.GA23210@fieldses.org> (raw)
In-Reply-To: <20211004225320.25368-1-dai.ngo@oracle.com>

On Mon, Oct 04, 2021 at 06:53:20PM -0400, Dai Ngo wrote:
> COUR3: Test OPEN file with OPEN4_SHARE_DENY_WRITE
> COUR4: Test Share Reservation. Test 2 clients with same deny mode
> COUR5: Test Share Reservation. Test Courtesy client's file access mode
>        conflicts with deny mode
> COUR6: Test Share Reservation. Test Courtesy client's deny mode conflicts
>        with file access mode

Thanks!

> @@ -73,6 +76,8 @@ def testLockSleepLock(t, env):
>  
>      c2 = env.c1.new_client(b"%s_2" % env.testname(t))
>      sess2 = c2.create_session()
> +    res = sess2.compound([op.reclaim_complete(FALSE)])
> +    check(res)

Nit: this is a separate bugfix, right?  I'd rather have that kind of
thing in a separate patch.

Also, you could just use new_client_session().

--b.

      reply	other threads:[~2021-10-05 15:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04 22:53 [PATCH 1/1] st_courtesy.py: add more tests for Courteous Server Dai Ngo
2021-10-05 15:22 ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211005152224.GA23210@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=dai.ngo@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).